chore[build]: add TestFX dependency #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* configure GitHub Actions to use TestFX in headless mode * upgrade JavaFX to 12
skaldarnar
added
Topic: CI/CD
skaldarnar
approved these changes
Oct 5, 2020
| @@ -15,4 +15,6 @@ jobs: | |||
| java-version: 14 | |||
| java-package: jdk | |||
| - name: Build and test with Gradle | |||
| env: | |||
| JAVA_TOOL_OPTIONS: -Dtestfx.robot=glass -Dtestfx.headless=true -Dprism.verbose=true | |||
There was a problem hiding this comment.
Should a developer use these flags locally as well?
There was a problem hiding this comment.
Only if you want to make sure your test environment matches the GitHub one. And there's certainly some value to that if you're trying to reproduce a failure that GitHub tells you about!
but it's not necessary if your development environment is running somewhere it can just as easily use a standard JavaFX backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to try to reduce the distance to the branch for #571.
I looked at trying to cherry-pick the actual commits from that branch, but it didn't seem like that was going to make sense.
I'm not entirely certain that these test dependencies are suitable for all the tests currently in the master branch, since some of those tests were removed or replaced in the other branch.
But we'll see what the CI builder thinks of it. Or maybe you don't care for those tests anyway, if you see this as a stepping stone.