-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Game Runner thread / subprocess improvements #571
Commits on Jun 1, 2020
-
Work in Progress: add slf4j-test
This is a slf4j provider made to write test assertions against. But there can be only one slf4j provider on your classpath at the same time, otherwise who knows which will be used. the remal.component-metadata plugin identifies a lot of these sorts of conflicts so they don't happen silently. but that doesn't have spf4j-slf4j-test in its list of things it knows about, so we also need to specify that. once you've identified conflicts, you have to resolve them, which takes ten lines for some reason, so I put it in a function. debugging wasn't working very well on scripts included with `apply from`, and that's how I ended up writing a gradle plugin.
Configuration menu - View commit details
-
Copy full SHA for b9236e1 - Browse repository at this point
Copy the full SHA b9236e1View commit details -
maintenance: convert TestGameRunner to using slf4j-test
with slight refactor to avoid mocking static method on Thread.
Configuration menu - View commit details
-
Copy full SHA for 97a9cac - Browse repository at this point
Copy the full SHA 97a9cacView commit details -
build.gradle: keep slf4j-api as an explicit dependency, but with flex…
…ibility to satisfy both app and test code.
Configuration menu - View commit details
-
Copy full SHA for 17a74e8 - Browse repository at this point
Copy the full SHA 17a74e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6a7d6d - Browse repository at this point
Copy the full SHA c6a7d6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bfed6b3 - Browse repository at this point
Copy the full SHA bfed6b3View commit details -
Work in Progress: We're going to have a GameStarter after all.
The more I look at it the more it circles back to the current design.
Configuration menu - View commit details
-
Copy full SHA for 431bec3 - Browse repository at this point
Copy the full SHA 431bec3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e84bcd - Browse repository at this point
Copy the full SHA 9e84bcdView commit details -
like `hasItems` but it checks from one collection you pass to it, not each one of a variable number of arguments.
Configuration menu - View commit details
-
Copy full SHA for d3bbf91 - Browse repository at this point
Copy the full SHA d3bbf91View commit details -
Configuration menu - View commit details
-
Copy full SHA for f16526e - Browse repository at this point
Copy the full SHA f16526eView commit details -
TestRunGameTask: split junit4 vintage tests
so other tests can use jupiter Extension
Configuration menu - View commit details
-
Copy full SHA for fc8c7f5 - Browse repository at this point
Copy the full SHA fc8c7f5View commit details -
TestRunGameTask has learned a lot of things about tasks and processes!
We use TestFX so the JavaFX Task has an Application Thread to run in.
Configuration menu - View commit details
-
Copy full SHA for c5d6ec9 - Browse repository at this point
Copy the full SHA c5d6ec9View commit details -
Replace the GameStarter Interface with Callable<Process>.
Configuration menu - View commit details
-
Copy full SHA for 67a6fb6 - Browse repository at this point
Copy the full SHA 67a6fb6View commit details -
Work in Progress: TestRunGameTask thinking about cancellation and pro…
…cess termination
Configuration menu - View commit details
-
Copy full SHA for 0a38ce0 - Browse repository at this point
Copy the full SHA 0a38ce0View commit details -
RunGameTask will throw an exception if the process fails to start or …
…if it exits with error
Configuration menu - View commit details
-
Copy full SHA for 16e2a5a - Browse repository at this point
Copy the full SHA 16e2a5aView commit details -
We don't have a well-defined spec for thread cancellation.
We don't want thread cancellation to terminate the process.
Configuration menu - View commit details
-
Copy full SHA for e3c03e9 - Browse repository at this point
Copy the full SHA e3c03e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d25b5f6 - Browse repository at this point
Copy the full SHA d25b5f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f4c4b6 - Browse repository at this point
Copy the full SHA 6f4c4b6View commit details -
Test process output parsing by providing a list of strings as an Inpu…
…tStream. 💭 "it'll be easy," they said.
Configuration menu - View commit details
-
Copy full SHA for c28761d - Browse repository at this point
Copy the full SHA c28761dView commit details -
Separate the in-memory mocks from the ones that spawn real processes …
…(or at least try to).
Configuration menu - View commit details
-
Copy full SHA for d03adf0 - Browse repository at this point
Copy the full SHA d03adf0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c369e98 - Browse repository at this point
Copy the full SHA c369e98View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae83f5e - Browse repository at this point
Copy the full SHA ae83f5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4caf3ba - Browse repository at this point
Copy the full SHA 4caf3baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 020f7d3 - Browse repository at this point
Copy the full SHA 020f7d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2b76d0 - Browse repository at this point
Copy the full SHA c2b76d0View commit details -
removing old GameRunner and JUnit Vintage
we don't use the annotation parts of spf4j-slf4j-test enough to keep Vintage around
Configuration menu - View commit details
-
Copy full SHA for 38fa977 - Browse repository at this point
Copy the full SHA 38fa977View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0883d01 - Browse repository at this point
Copy the full SHA 0883d01View commit details -
upgrade game log output from TRACE to INFO
This does is a spec change, but the best way to avoid this "test failure won't show us TRACE output unless we use the @CollectLogs decorator" is to not rely on TRACE output. Especially since we want game output more visible anyway, for troubleshooting on launch failure.
Configuration menu - View commit details
-
Copy full SHA for 3ee4bd7 - Browse repository at this point
Copy the full SHA 3ee4bd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff45b5b - Browse repository at this point
Copy the full SHA ff45b5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 397f7cd - Browse repository at this point
Copy the full SHA 397f7cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3bca0a - Browse repository at this point
Copy the full SHA f3bca0aView commit details -
GameService to get the nitty-gritty details of the thread factory out…
… of ApplicationController
Configuration menu - View commit details
-
Copy full SHA for 19bc1ed - Browse repository at this point
Copy the full SHA 19bc1edView commit details -
GradleGoo.prefers: provide Action<ResolutionStrategy> for a more grad…
…le-like interface
Configuration menu - View commit details
-
Copy full SHA for 2020f83 - Browse repository at this point
Copy the full SHA 2020f83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d3eb77 - Browse repository at this point
Copy the full SHA 7d3eb77View commit details -
Configuration menu - View commit details
-
Copy full SHA for f89f1b7 - Browse repository at this point
Copy the full SHA f89f1b7View commit details -
Service lets the Controller bind handlers just once.
Instead of having to re-bind every time we do a new run.
Configuration menu - View commit details
-
Copy full SHA for 8d544c6 - Browse repository at this point
Copy the full SHA 8d544c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03bb551 - Browse repository at this point
Copy the full SHA 03bb551View commit details -
GameService: simplify executor, as Service doesn't need it for its im…
…plementation of isRunning.
Configuration menu - View commit details
-
Copy full SHA for 2655b32 - Browse repository at this point
Copy the full SHA 2655b32View commit details -
Configuration menu - View commit details
-
Copy full SHA for af7357f - Browse repository at this point
Copy the full SHA af7357fView commit details -
https://github.com/TomasMikula/ReactFX/blob/v2.0-M5/reactfx/src/main/java/org/reactfx/util/FxTimer.java Copyright (c) 2013-2014, Tomas Mikula licensed under http://opensource.org/licenses/BSD-2-Clause
Configuration menu - View commit details
-
Copy full SHA for ce704fa - Browse repository at this point
Copy the full SHA ce704faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b002a5 - Browse repository at this point
Copy the full SHA 6b002a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c49c377 - Browse repository at this point
Copy the full SHA c49c377View commit details -
GameService: do the GameStarter construction here
This makes the dependency graph feel pretty good to me. GameService is responsible for translating Config/Settings to something RunGameTask needs.
Configuration menu - View commit details
-
Copy full SHA for 077ba1d - Browse repository at this point
Copy the full SHA 077ba1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0082b7c - Browse repository at this point
Copy the full SHA 0082b7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a568d99 - Browse repository at this point
Copy the full SHA a568d99View commit details -
GameStarter: combine error stream with output stream
otherwise we would need _another_ thread to watch the error stream.
Configuration menu - View commit details
-
Copy full SHA for d0cdae6 - Browse repository at this point
Copy the full SHA d0cdae6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71b3dbe - Browse repository at this point
Copy the full SHA 71b3dbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5250471 - Browse repository at this point
Copy the full SHA 5250471View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fd3151 - Browse repository at this point
Copy the full SHA 8fd3151View commit details -
Configuration menu - View commit details
-
Copy full SHA for a964476 - Browse repository at this point
Copy the full SHA a964476View commit details -
Configuration menu - View commit details
-
Copy full SHA for 338ea23 - Browse repository at this point
Copy the full SHA 338ea23View commit details -
Configuration menu - View commit details
-
Copy full SHA for a06a2c6 - Browse repository at this point
Copy the full SHA a06a2c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 627d627 - Browse repository at this point
Copy the full SHA 627d627View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e9d3e1 - Browse repository at this point
Copy the full SHA 6e9d3e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9efa232 - Browse repository at this point
Copy the full SHA 9efa232View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2267df - Browse repository at this point
Copy the full SHA f2267dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79fecfb - Browse repository at this point
Copy the full SHA 79fecfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d43b8df - Browse repository at this point
Copy the full SHA d43b8dfView commit details -
fix(RunGameTask): throw GameExitTooSoon if it quit early
without this, "quit launcher after start" could be frustrating.
Configuration menu - View commit details
-
Copy full SHA for 676da02 - Browse repository at this point
Copy the full SHA 676da02View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec6efd7 - Browse repository at this point
Copy the full SHA ec6efd7View commit details -
feat(RunGameTask): default message to string
otherwise the logger shows `null`
Configuration menu - View commit details
-
Copy full SHA for 4a82b4d - Browse repository at this point
Copy the full SHA 4a82b4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4df2589 - Browse repository at this point
Copy the full SHA 4df2589View commit details -
Configuration menu - View commit details
-
Copy full SHA for b91167d - Browse repository at this point
Copy the full SHA b91167dView commit details
Commits on Sep 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 6667350 - Browse repository at this point
Copy the full SHA 6667350View commit details
Commits on Oct 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for aa70a8b - Browse repository at this point
Copy the full SHA aa70a8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07cb1d8 - Browse repository at this point
Copy the full SHA 07cb1d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09859e7 - Browse repository at this point
Copy the full SHA 09859e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6693419 - Browse repository at this point
Copy the full SHA 6693419View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55c74d5 - Browse repository at this point
Copy the full SHA 55c74d5View commit details