Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove Swagger configuration #569

Merged
merged 3 commits into from
May 8, 2020
Merged

Conversation

skaldarnar
Copy link
Member

@skaldarnar skaldarnar commented May 8, 2020

Unfortunately, this has become dead code that was never used. We still have plans to support control of servers via a RESTful web interface, and integrate that with the launcher.

Until then, we don't want to bother about the technical dept this brings in the meantime.

Related to #565

Unfortunately, this has become dead code that was never used. We still have plans to support control of servers via a RESTful web interface, and integrate that with the launcher.
Until then, we don't want to bother about the technical dept this brings in the meantime.
@skaldarnar skaldarnar added Topic: CI/CD Related to CI/CD and build infrastructure (excluded from the Changelog) Type: Maintenance Maintenance or chores not adding new features or fixing bugs. labels May 8, 2020
@keturn
Copy link
Member

keturn commented May 8, 2020

Is there any code in src/ related to this? Or was it all compile-time config?

@skaldarnar
Copy link
Member Author

Afaik it was just the compile-/build-time config to generate some Swagger/OpenAPI stubs which never got used...

@skaldarnar skaldarnar merged commit 29ad710 into master May 8, 2020
@skaldarnar skaldarnar deleted the topic/remove-open-api branch May 8, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: CI/CD Related to CI/CD and build infrastructure (excluded from the Changelog) Type: Maintenance Maintenance or chores not adding new features or fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants