-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Platform-specific distribution packages #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine for windows.
According to @praj-foss the .desktop
would need to be copied to ~/.local/share/applications/
.
We don't have a hard requirement for the .desktop
file and it's easier to set this up with an installer script (which is one of our 4.x targets). So, let's only put the launcher start binary/script at the archive top-level and delay the .desktop
file to after the v4.0 release.
config/gradle/jre.gradle
Outdated
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespaces
Works well for 64-bit Linux 👍
Could well be, though, that that's a flaw in my setup. @praj-foss could you double-check whether 32-bit works on your linux? |
I tested both Linux32 and Linux64 installs, and both seem to start alright. 👍 Linux32: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully tested for 32- and 64-bit Windows 👍
Clean up and improve packaging for Windows and Linux.
Addressing #492
To test you can run:
to install the distribution to
build/install/<distributionName>
, e.g.,./gradlew installLinux64Dist
.Packaging for all platforms can be tested via
./gradlew createRelease
.