Skip to content

Commit

Permalink
upgrade game log output from TRACE to INFO
Browse files Browse the repository at this point in the history
This does is a spec change, but the best way to avoid this "test failure won't show us TRACE output unless we use the @CollectLogs decorator" is to not rely on TRACE output.

Especially since we want game output more visible anyway, for troubleshooting on launch failure.
  • Loading branch information
keturn committed May 8, 2020
1 parent a12984b commit 69dbd2b
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,10 @@ public void testGameOutput() throws InterruptedException, RunGameTask.GameExitEr

var hasGameOutputFormat = LogMatchers.hasFormatWithPattern("^Game output.*");

LogAssert detailedExpectation = TestLoggers.sys().expect(RunGameTask.class.getName(), Level.TRACE,
allOf(hasGameOutputFormat, LogMatchers.hasArguments(gameOutputLines[0])),
allOf(hasGameOutputFormat, LogMatchers.hasArguments(gameOutputLines[1]))
LogAssert detailedExpectation = TestLoggers.sys().expect(
RunGameTask.class.getName(), Level.INFO,
allOf(hasGameOutputFormat, LogMatchers.hasArguments(gameOutputLines[0])),
allOf(hasGameOutputFormat, LogMatchers.hasArguments(gameOutputLines[1]))
);

gameTask.monitorProcess(gameProcess);
Expand Down

0 comments on commit 69dbd2b

Please sign in to comment.