Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

适配新版本adapter-satori #169

Merged
merged 1 commit into from
Aug 4, 2024
Merged

适配新版本adapter-satori #169

merged 1 commit into from
Aug 4, 2024

Conversation

AzideCupric
Copy link
Contributor

adapter-satori 在v0.12做了一些models上的改动

Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for send-anything-anywhere ready!

Name Link
🔨 Latest commit 87790e2
🔍 Latest deploy log https://app.netlify.com/sites/send-anything-anywhere/deploys/66a898e28d70880008f907ec
😎 Deploy Preview https://deploy-preview-169--send-anything-anywhere.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.88%. Comparing base (537ec7b) to head (87790e2).

Files Patch % Lines
nonebot_plugin_saa/adapters/satori.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files          27       27           
  Lines        2282     2282           
=======================================
  Hits         2188     2188           
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felinae98
Copy link
Collaborator

理论上属于 break 行为,发个版?

@AzideCupric
Copy link
Contributor Author

AzideCupric commented Jul 30, 2024

理论上属于 break 行为,发个版?

发版肯定得发,但是这对saa这边的用户来说应该是无感的?

Copy link
Collaborator

如果假设用户不关心他装了那个版本的 adapter 的话,那不感知;但是严格来说我们不支持老版本的 adapter 了

@felinae98 felinae98 added dependencies change dependency Breaking breaking changes labels Aug 4, 2024
@felinae98 felinae98 changed the title ✨ 适配新版本adapter-satori 适配新版本adapter-satori Aug 4, 2024
@felinae98 felinae98 merged commit 0cc87b1 into main Aug 4, 2024
19 of 20 checks passed
@felinae98 felinae98 deleted the adapter/satori branch August 4, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking breaking changes dependencies change dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants