Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

去除MessageFactory和MessageSegmentFactory的泛型，补充成员方法 #128

Merged
merged 8 commits into from
Dec 29, 2023
Merged

去除MessageFactory和MessageSegmentFactory的泛型，补充成员方法 #128

merged 8 commits into from
Dec 29, 2023

Conversation

AzideCupric
Copy link
Contributor

No description provided.

@netlify Netlify
Copy link

netlify bot commented Dec 27, 2023 •
edited
Loading

✅ Deploy Preview for send-anything-anywhere ready!

Name Link
🔨 Latest commit bf45bcd
🔍 Latest deploy log https://app.netlify.com/sites/send-anything-anywhere/deploys/658e51f8cc437e000883cb7d
😎 Deploy Preview https://deploy-preview-128--send-anything-anywhere.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Dec 27, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6985677) 95.86% compared to head (bf45bcd) 96.10%.
Report is 1 commits behind head on main.

Files Patch % Lines
nonebot_plugin_saa/abstract_factories.py 98.05% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   95.86%   96.10%   +0.24%     
==========================================
  Files          25       25              
  Lines        1814     1927     +113     
==========================================
+ Hits         1739     1852     +113     
  Misses         75       75

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AzideCupric
Copy link
Contributor Author

AzideCupric commented Dec 27, 2023 •
edited
Loading

Deprecated #127

@AzideCupric AzideCupric changed the title ✨ 去除MessageFactory和MessageSegmentFactory的泛型，补充成员方法，为Receipt添加获取对应MessageId的方法 ✨ 去除MessageFactory和MessageSegmentFactory的泛型，补充成员方法 Dec 28, 2023
felinae98
felinae98 reviewed Dec 28, 2023
View reviewed changes
CHANGELOG.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好像是rebase的时候不小心弄进来的

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

快把它干掉

nonebot_plugin_saa/abstract_factories.py Show resolved Hide resolved
nonebot_plugin_saa/abstract_factories.py Outdated Show resolved Hide resolved
nonebot_plugin_saa/abstract_factories.py Outdated Show resolved Hide resolved
@felinae98 felinae98 added the feature new feature label Dec 29, 2023
@felinae98 felinae98 changed the title ✨ 去除MessageFactory和MessageSegmentFactory的泛型，补充成员方法 去除MessageFactory和MessageSegmentFactory的泛型，补充成员方法 Dec 29, 2023
@felinae98 felinae98 merged commit 36fc402 into main Dec 29, 2023
19 checks passed
@felinae98 felinae98 deleted the typing/messagefactory2 branch December 29, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felinae98 felinae98 felinae98 approved these changes

Assignees
No one assigned
Labels
feature new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AzideCupric @felinae98