fix: fix crash in text analysis when proper nouns disabled

Moseco · Oct 1, 2024 · 7fcc687 · 7fcc687
1 parent 6fd6d57
commit 7fcc687
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/services/dictionary_service.dart b/lib/services/dictionary_service.dart
@@ -537,7 +537,9 @@ class DictionaryService {
   Future<List<ProperNoun>> getProperNounByJapaneseTextToken(
     JapaneseTextToken token,
   ) async {
-    if (token.base.contains(constants.kanjiRegExp)) {
+    if (_kanaKit.isKana(token.base)) {
+      return _database.properNounsDao.getByReading(token.base);
+    } else {
       final results = await _database.properNounsDao.getByWritingAndReading(
         token.base,
         _kanaKit.toHiragana(token.baseReading),
@@ -548,8 +550,6 @@ class DictionaryService {
       } else {
         return results;
       }
-    } else {
-      return _database.properNounsDao.getByReading(token.base);
     }
   }
 

diff --git a/lib/ui/views/text_analysis/text_analysis_viewmodel.dart b/lib/ui/views/text_analysis/text_analysis_viewmodel.dart
@@ -67,6 +67,8 @@ class TextAnalysisViewModel extends FutureViewModel {
         if (_sharedPreferencesService.getProperNounsEnabled()) {
           token.associatedDictionaryItems =
               await _dictionaryService.getProperNounByJapaneseTextToken(token);
+        } else {
+          token.associatedDictionaryItems = [];
         }
       } else {
         token.associatedDictionaryItems =