Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated flutter platforms #110

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Updated flutter platforms #110

wants to merge 11 commits into from

Conversation

FaFre
Copy link

@FaFre FaFre commented Oct 29, 2023

This PR adds Linux support and recreates android/ios structures, as well as the outdated metadata file.

@FaFre FaFre marked this pull request as ready for review October 29, 2023 06:58
Copy link
Owner

@Mosc Mosc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a Linux development machine to test this on, so I trust you that this is working well. :)

android/app/src/debug/AndroidManifest.xml Outdated Show resolved Hide resolved
ios/RunnerTests/RunnerTests.swift Outdated Show resolved Hide resolved
linux/my_application.cc Outdated Show resolved Hide resolved
linux/my_application.cc Outdated Show resolved Hide resolved
@FaFre
Copy link
Author

FaFre commented Nov 15, 2023

@Mosc all done

@FaFre
Copy link
Author

FaFre commented Nov 15, 2023

@Mosc I also got web working locally. It required some minor code changes. However, the HN login doesn't work since in the browser CORS comes into game. Shall I push this changes or are you planning to not support web anyways?

@Mosc
Copy link
Owner

Mosc commented Nov 15, 2023

@Mosc I also got web working locally. It required some minor code changes. However, the HN login doesn't work since in the browser CORS comes into game. Shall I push this changes or are you planning to not support web anyways?

Web support is not that different from Linux support in that respect: I'm not going to use it personally and I don't have plans to officially distribute it, but if others gain value from it I don't mind having it included in the repository. As long as the effect on the code is not too invasive you should feel free to push it.

It's interesting that you mention the login functionality not working, because isn't the same true for the Linux target? Or do you mean that it fails in a different way?

Copy link
Owner

@Mosc Mosc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In its current state I'd be happy to merge the PR, but let me know if you want to add web support first.

@FaFre
Copy link
Author

FaFre commented Nov 17, 2023

I just pushed the web support. One small dependency is required, because dart:io is not available for web.

@Mosc
Copy link
Owner

Mosc commented Nov 21, 2023

I have some issues with universal_io being included for a single line of code. As I understand it the if (Platform.isAndroid) wouldn't work otherwise, right? How about changing that to if (!kIsWeb && defaultTargetPlatform == TargetPlatform.android)?

Please also add the following to flutter_launcher_icons.yaml to generate Glider favicons rather than the default Flutter one, and then run flutter pub run flutter_launcher_icons:

  web:
    generate: true

Unfortunately that tool doesn't support Linux yet! Exclude any icon changes for other platforms, those have been optimized for size.

@FaFre
Copy link
Author

FaFre commented Jan 22, 2024

@Mosc I finally found some time to fix the open points :)

Linking the Linux related issue for future references: fluttercommunity/flutter_launcher_icons#529

@FaFre FaFre mentioned this pull request Feb 8, 2024
@Mosc
Copy link
Owner

Mosc commented Apr 2, 2024

Apologies for the late reply. I think the PR mostly looks good, but the changes to the existing icons should be reverted. They're larger than the current icon file sizes.

Exclude any icon changes for other platforms, those have been optimized for size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants