-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated flutter platforms #110
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a Linux development machine to test this on, so I trust you that this is working well. :)
Co-authored-by: Mosc <[email protected]>
Co-authored-by: Mosc <[email protected]>
This reverts commit a6e9203.
@Mosc all done |
@Mosc I also got web working locally. It required some minor code changes. However, the HN login doesn't work since in the browser CORS comes into game. Shall I push this changes or are you planning to not support web anyways? |
Web support is not that different from Linux support in that respect: I'm not going to use it personally and I don't have plans to officially distribute it, but if others gain value from it I don't mind having it included in the repository. As long as the effect on the code is not too invasive you should feel free to push it. It's interesting that you mention the login functionality not working, because isn't the same true for the Linux target? Or do you mean that it fails in a different way? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In its current state I'd be happy to merge the PR, but let me know if you want to add web support first.
I just pushed the web support. One small dependency is required, because |
I have some issues with Please also add the following to web:
generate: true Unfortunately that tool doesn't support Linux yet! Exclude any icon changes for other platforms, those have been optimized for size. |
@Mosc I finally found some time to fix the open points :) Linking the Linux related issue for future references: fluttercommunity/flutter_launcher_icons#529 |
Apologies for the late reply. I think the PR mostly looks good, but the changes to the existing icons should be reverted. They're larger than the current icon file sizes.
|
This PR adds Linux support and recreates android/ios structures, as well as the outdated metadata file.