Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

85 add a problemswarningserrors panel #89

Merged
merged 31 commits into from
Jun 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
292910e
remove unused editor panel functions, add compiler info on success ha…
Moros1138 Jun 4, 2024
0beeba8
remove unused monaco
Moros1138 Jun 4, 2024
a3f1fa7
add restart after disconnect
Moros1138 Jun 5, 2024
ea5fd0b
remove preformatted style
Moros1138 Jun 5, 2024
de596a5
add focus to editor
Moros1138 Jun 5, 2024
598c6e8
set the cursor position and set editor focused in the reveal function
Moros1138 Jun 5, 2024
1d93b33
handleDiagnostics middleware
Moros1138 Jun 5, 2024
8fe9140
wip problems in the #info-panel
Moros1138 Jun 5, 2024
d82cda9
pretty looking errors in the info panel
Moros1138 Jun 6, 2024
05e52f1
wrapping pre-formatted text for the info panel after builds
Moros1138 Jun 6, 2024
83c6a3f
shame on moros if he leaves this here
Moros1138 Jun 6, 2024
d04016e
fix mobile oversize
Moros1138 Jun 7, 2024
63129ec
add guards if the monaco wrapper hasn't been started
Moros1138 Jun 7, 2024
ebb72aa
let monaco hover hints overlap the layout
Moros1138 Jun 7, 2024
6597792
gut restart attempt
Moros1138 Jun 8, 2024
7eca431
remove info panel
Moros1138 Jun 8, 2024
dd2575d
add compiler output panel
Moros1138 Jun 8, 2024
435a0bc
refactor console panel
Moros1138 Jun 8, 2024
3242779
use new storage method in editor/code
Moros1138 Jun 8, 2024
2016a22
add problems panel
Moros1138 Jun 8, 2024
6686898
remove old default layout
Moros1138 Jun 8, 2024
5bee0a3
new storage system
Moros1138 Jun 8, 2024
adab469
default layouts for portrait and landscape modes
Moros1138 Jun 8, 2024
8d9bc17
use new storage, add new layouts, add problems panel, add compiler ou…
Moros1138 Jun 8, 2024
74c986d
remove moros shaming, the task is complete
Moros1138 Jun 8, 2024
2282af3
make problems cells of specific width, so as to not change very time …
Moros1138 Jun 8, 2024
c061a9b
make problems panel focused when it's state changes.
Moros1138 Jun 8, 2024
78941c5
set focus to editor and problems panels
Moros1138 Jun 8, 2024
a065f7e
only change to console on the first run of the program
Moros1138 Jun 8, 2024
ac6fc8d
update changelog
Moros1138 Jun 8, 2024
92c0a9d
adjust browser tests to match new ui elements
Moros1138 Jun 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@ All notable changes to this project will be documented in this file. Each batch

It is a summary of changes that would be pertinent to the end user of the PGEtinker website. For a comprehensive history of changes made to the project, please refer to the repository's commit history.

## 2024-06-08

- Fixed mobile overize issue (big win for mobile)
- Added diagnostics middleware to monaco language client
- Changed Build Information panel to Compiler Output
- Added Problems panel
- Removed old default layout
- Added default layout for portrait
- Added default layout for landscape
- Added storage abstraction

## 2024-06-04

- Added Alert when a runtime error occurs
Expand Down
14 changes: 12 additions & 2 deletions resources/css/app.scss
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,11 @@ body.light {

html,
body {
position: relative;
width: 100%;
height: 100%;
margin: 0;
padding: 0;
overflow: hidden;
font-family: 'Pixel Code', monospace;
font-size: 12px;
Expand All @@ -73,7 +76,7 @@ a:hover {
}

#app {
position: fixed;
position: absolute;
top: 0;
left: 0;
width: 100%;
Expand Down Expand Up @@ -216,6 +219,8 @@ nav .navbar-right-menu .menu-item {
bottom: 0px;
width: 100%;
overflow: hidden;
margin: 0;
padding: 0;
border-top: 1px solid var(--pgetinker-content-border-color);
border-bottom: 1px solid var(--pgetinker-content-border-color);
}
Expand All @@ -227,9 +232,14 @@ nav .navbar-right-menu .menu-item {
.hidden { display: none; }

@import "./console-panel.scss";
@import "./compiler-output-panel.scss";
@import "./editor-panel.scss";
@import "./info-panel.scss";
@import "./player-panel.scss";
@import "./problems-panel.scss";
@import "./dialog.scss";

@import "./responsive.scss";

.lm_content {
overflow: visible !important;
}
18 changes: 18 additions & 0 deletions resources/css/compiler-output-panel.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#compiler-output-panel {
position: absolute;
top: 0;
left: 0;
right: 0;
bottom: 0;
overflow: auto;
}

#compiler-output-panel > div {
font-family: "Droid Sans Mono", "monospace", monospace;
width: 100%;
white-space: pre-wrap; /* Since CSS 2.1 */
white-space: -moz-pre-wrap; /* Mozilla, since 1999 */
white-space: -pre-wrap; /* Opera 4-6 */
white-space: -o-pre-wrap; /* Opera 7 */
word-wrap: break-word; /* Internet Explorer 5.5+ */
}
2 changes: 1 addition & 1 deletion resources/css/editor-panel.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
position: relative;
width: 100%;
height: 100%;
overflow: visible;
}

#editor-panel .code-editor {
Expand All @@ -17,7 +18,6 @@
left: 0;
right: 0;
bottom: 0px;
width: 100%;
height: 1.2rem;
line-height: 1.2rem;
font-size: 0.8rem;
Expand Down
14 changes: 0 additions & 14 deletions resources/css/info-panel.scss

This file was deleted.

80 changes: 80 additions & 0 deletions resources/css/problems-panel.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
#problems-panel {
position: absolute;
top: 0;
left: 0;
right: 0;
bottom: 0;
overflow: auto;
}

#problems-panel > div {
font-family: "Droid Sans Mono", "monospace", monospace;
width: 100%;
white-space: pre-wrap; /* Since CSS 2.1 */
white-space: -moz-pre-wrap; /* Mozilla, since 1999 */
white-space: -pre-wrap; /* Opera 4-6 */
white-space: -o-pre-wrap; /* Opera 7 */
word-wrap: break-word; /* Internet Explorer 5.5+ */
}

#problems-panel table {
font-family: "Droid Sans Mono", "monospace", monospace;
border-spacing: 0;
width: 100%;
}

#problems-panel table thead {
position: sticky;
font-weight: bolder;
text-decoration: underline;
inset-block-start: 0;
background-color: var(--pgetinker-background-color);
}

#problems-panel table thead tr td:nth-child(1) {
width: 15vw;
}

#problems-panel table thead tr td:nth-child(2) {
width: 5vw;
}

#problems-panel table thead tr td:nth-child(3) {
width: 5vw;
}

#problems-panel table thead tr td:nth-child(4) {
width: 100%;
}

#problems-panel table tr.error {
background-color: rgba(255,0,0,0.2);
}

#problems-panel table tr.warning {
background-color: rgba(255,255,0,0.2);
}

#problems-panel table tr.info {
background-color: rgba(0,0,255,0.2);
}

#problems-panel table tr.hint {
background-color: rgba(0, 255, 255,0.2);
}

#problems-panel table tbody tr:hover {
background-color: rgba(255, 255, 255, 0.2);
text-decoration: underline;
cursor: pointer;
}

#problems-panel table tr {
text-align: left;
}

#problems-panel table tr th,
#problems-panel table tr td {
padding: 0.3rem;
padding-left: 1rem;
}
Loading