Maven cleanup #216
Merged
Maven cleanup #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exec-maven-plugin is not used anywhere. Also it's not useful as Maven extension, but rather as a plugin only, AFAIK. From the history it looks like someone wanted to configure Tycho as extension, but didn't use the right Maven coordinates, thereby ending with the exec-maven-plugin as extension.
It's generally a good practice to have as many configuration values as possible in the pluginManagement section, as they will then surely be used in all modules inheriting from this parent. If configuration values are in the plugin section (or in a nested execution configuration), then a second invocation of that same plugin in another Maven module might not use the same configuration values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up Maven build (see separate commits).