Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: rm/uninstall not working when 'v' is missing for neovim versions. #225

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

matdexir
Copy link
Contributor

fixes #224
Let me know what you think!

@MordechaiHadad
Copy link
Owner

Although this solution seems fine enough, why not switch it to tag_name instead of the non_parsed_string?

@matdexir
Copy link
Contributor Author

matdexir commented Jul 14, 2024

@MordechaiHadad
That was actually my first thought but I just left it as is because I was afraid of breaking compatibility with nightly/commit based directories.
I am not too sure how they work since I did not dive deep into that part of the code

@MordechaiHadad
Copy link
Owner

@MordechaiHadad That was actually my first thought but I just left it as is because I was afraid of breaking compatibility with nightly/commit based directories. I am not too sure how they work since I did not dive deep into that part of the code

Fair enough then, fix the clippy errors and done.

Another way is just add

@matdexir
Copy link
Contributor Author

should be fixed now!

@MordechaiHadad MordechaiHadad merged commit 0119f3b into MordechaiHadad:master Jul 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: rm/uninstall/remove is not working as intended
2 participants