-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for Github API key #157 #161
Conversation
resolves #157
@MordechaiHadad First time trying rust lang. Please take a look at implementation and it works as expected for me. Usage (one of the example): GITHUB_TOKEN=<your token> bob update -a or as normal usage, bob update -a |
Also if you can, add to the readme that it is possible to add ur github token to be used with bob |
done. |
Move it to configuration part in the README, and test if it works correctly if the env var doesn't exist. |
Done with more detail. Feel free to update the way you like it if I am missing anything here.
Tried it on my rate-limit network and works as expected. ~/Documents/bob on github-api is 📦 v2.6.0 via 🦀 v1.73.0
➜ cargo build && ./target/debug/bob update -a
Finished dev [unoptimized + debuginfo] target(s) in 0.03s
Nov 08 10:11:23.177 INFO Fetching latest version
Nov 08 10:11:23.320 ERROR Error: invalid type: map, expected a sequence at line 1 column 0
~/Documents/bob on github-api is 📦 v2.6.0 via 🦀 v1.73.0
➜ GITHUB_TOKEN=<some token> cargo run update -a
Finished dev [unoptimized + debuginfo] target(s) in 0.03s
Running `target/debug/bob update -a`
Nov 08 10:11:30.382 INFO Fetching latest version
Nov 08 10:11:31.095 INFO Looking for nightly updates
Nov 08 10:11:31.096 INFO Nightly is already updated! |
Beautiful, thank you @dhruvinsh |
resolves #157