Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Github API key #157 #161

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Adding support for Github API key #157 #161

merged 5 commits into from
Nov 8, 2023

Conversation

dhruvinsh
Copy link
Contributor

resolves #157

@dhruvinsh
Copy link
Contributor Author

@MordechaiHadad First time trying rust lang. Please take a look at implementation and it works as expected for me.

Usage (one of the example):

GITHUB_TOKEN=<your token> bob update -a

or as normal usage,

bob update -a

src/cli.rs Outdated Show resolved Hide resolved
@MordechaiHadad
Copy link
Owner

MordechaiHadad commented Nov 8, 2023

Also if you can, add to the readme that it is possible to add ur github token to be used with bob

@dhruvinsh
Copy link
Contributor Author

Also if you can, add to the readme that it is possible to add ur github token to be used with bob

done.

@MordechaiHadad
Copy link
Owner

Also if you can, add to the readme that it is possible to add ur github token to be used with bob

done.

Move it to configuration part in the README, and test if it works correctly if the env var doesn't exist.
after that it is ready for merge!

@dhruvinsh
Copy link
Contributor Author

Move it to configuration part in the README

Done with more detail. Feel free to update the way you like it if I am missing anything here.

test if it works correctly if the env var doesn't exist.

Tried it on my rate-limit network and works as expected.

~/Documents/bob on  github-api is 📦 v2.6.0 via 🦀 v1.73.0 cargo build && ./target/debug/bob update -a
    Finished dev [unoptimized + debuginfo] target(s) in 0.03s
Nov 08 10:11:23.177  INFO Fetching latest version
Nov 08 10:11:23.320 ERROR Error: invalid type: map, expected a sequence at line 1 column 0

~/Documents/bob on  github-api is 📦 v2.6.0 via 🦀 v1.73.0 GITHUB_TOKEN=<some token> cargo run update -a
    Finished dev [unoptimized + debuginfo] target(s) in 0.03s
     Running `target/debug/bob update -a`
Nov 08 10:11:30.382  INFO Fetching latest version
Nov 08 10:11:31.095  INFO Looking for nightly updates
Nov 08 10:11:31.096  INFO Nightly is already updated!

@MordechaiHadad
Copy link
Owner

MordechaiHadad commented Nov 8, 2023

Beautiful, thank you @dhruvinsh

@MordechaiHadad MordechaiHadad merged commit 7f9195f into MordechaiHadad:master Nov 8, 2023
8 checks passed
@dhruvinsh dhruvinsh deleted the github-api branch November 8, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] support for Github API keys
2 participants