Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: token endpoint added for SolanaApi #60

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Feat: token endpoint added for SolanaApi #60

wants to merge 8 commits into from

Conversation

3scava1i3r
Copy link

Work done

Work in progress

  • testing the same on unity
  • Documentation on Readme.Md

@3scava1i3r
Copy link
Author

Some of my questions are as follows -

  • I seem to have less idea as to how to add .cs.meta files
  • How do i test the code endpoints that i have created

xactant
xactant reviewed Aug 30, 2022
View reviewed changes
Runtime/SolanaApi/CloudApi/TokenApi.cs Outdated
public ApiClient ApiClient { get; set; }


public async UniTask<TokenPrice> GetTokenPrice(NetworkTypes network, string address) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow coding practices in other files - braces should be on a new line.

xactant
xactant reviewed Aug 30, 2022
View reviewed changes
Runtime/SolanaApi/Api/TokenApi.cs Outdated

namespace MoralisUnity.SolanaApi.Api
{
public class TokenApi : ITokenApi;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add descriptive comments to all public classes and methods

xactant
xactant suggested changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@xactant xactant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission - please see comments

@3scava1i3r 3scava1i3r requested a review from xactant August 31, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xactant xactant Awaiting requested review from xactant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3scava1i3r @xactant