fix: 🐛 change payment stream update logic to delete if user is insolvent #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… user is insolvent
snowmead
reviewed
Nov 27, 2024
ffarall
reviewed
Dec 5, 2024
TDemeco
changed the title
update_x_payment_stream functions to not error out if user is insolvent
ffarall
approved these changes
Dec 11, 2024
| assert_ok!(<crate::Pallet<Test> as MutateBucketsInterface>::decrease_bucket_size(&bucket_id, 50)); | ||
|
|
||
| // Check that the payment stream was deleted | ||
| assert!(!<<Test as crate::Config>::PaymentStreams as PaymentStreamsInterface>::has_active_payment_stream(&msp_id, &bucket_owner)); |
There was a problem hiding this comment.
I'd add a decrease_bucket_size call for a second time. To highlight that this still works after the payment stream is deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the logic of updating payment streams. Now, whenever a call to update a payment stream is done, we check beforehand if the user is currently insolvent and if so, call the delete payment stream function instead.