remove useless NimbusBlockImport #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't parachain nodes import blocks as best this way? Is that desired now? |
|
It was a suggestion from parity but for some reasons it doesn't work |
|
What are you trying to do? Maybe I can share an idea or two. |
RomarQ
requested review from
crystalin,
girazoki,
tmpolaczyk,
ahmadkaouk and
Agusrodri
Context for the change: paritytech/polkadot-sdk#4333 (comment) |
|
A bit more context to @JoshOrndorff (if you are still around, "Hi" btw :p). Right now import is done from blocks marked as "best" by the relay, but that is slow for user interaction (tx take like 18s to be "validated") so we are now using the "imported" block directly. |
gonzamontiel
approved these changes
Nov 20, 2024
Agusrodri
approved these changes
Nov 20, 2024
|
@girazoki Are you fine with the changes included in this PR? |
RomarQ
added a commit
that referenced
this pull request
Nov 22, 2024
* remove useless NimbusBlockImport * fix format * remove use of new_with_delayed_best_block from template * keep but deprecate old behaviour --------- Co-authored-by: Éloïs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was authored by @librelois and is part of the work related to the transaction pool improvements on moonbeam.
Historically aura was overcharging fork strategy for parachain at block import, but it's seems no longer necessary.