Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests #4

Merged
merged 29 commits into from
Jun 6, 2024
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
8ed92e0
Feature: bootloader hint processor
odesenfans May 22, 2024
c10fc8d
Add cairo-lang as dependency
odesenfans May 23, 2024
18da9bf
wip readme
odesenfans May 23, 2024
bf827da
add bootloader
odesenfans May 24, 2024
4935a4a
example comments
odesenfans May 24, 2024
fb2312f
example of fix
odesenfans May 24, 2024
179a1a1
Feature: bootloader hint processor
odesenfans May 22, 2024
c7a440e
add bootloader
odesenfans May 24, 2024
75ed509
example of fix
odesenfans May 24, 2024
23701d5
Merge branch 'feat/fix-tests' of github.com:Moonsong-Labs/cairo-bootl…
whichqua Jun 3, 2024
051714b
fix: get tests compiling and running
whichqua Jun 3, 2024
418f224
fix: get most tests passing
whichqua Jun 5, 2024
bfc6988
update: set the correct path of deps
whichqua Jun 5, 2024
cf51892
update: set the correct path of deps
whichqua Jun 5, 2024
6234733
add: test-programs submodule
whichqua Jun 5, 2024
daacd87
update: the missing dependencies
whichqua Jun 5, 2024
a76fec3
lint: clippy
whichqua Jun 5, 2024
3597f30
lint: rustfmt
whichqua Jun 5, 2024
a03588e
lint: clippy
whichqua Jun 5, 2024
1481c3c
move test-programs + fix PIE loading
odesenfans Jun 5, 2024
ef1e51f
fix bootloader identifiers
odesenfans Jun 5, 2024
de16faf
reactivate ci
odesenfans Jun 5, 2024
9dadc09
submodules
odesenfans Jun 5, 2024
3f2c057
remove: dbg points
whichqua Jun 5, 2024
81deb99
fix: based on review
whichqua Jun 6, 2024
1a79f21
fix: some minor improvements
whichqua Jun 6, 2024
ee051f1
lint: rustfmt
whichqua Jun 6, 2024
fa29438
fix: missing newline
whichqua Jun 6, 2024
9617263
fix: remove unused macro
whichqua Jun 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: "true"
- run: rustup show
- run: rustup component add rustfmt
- uses: Swatinem/rust-cache@v2
Expand All @@ -20,6 +22,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: "true"
- run: rustup show
- uses: Swatinem/rust-cache@v2
- run: cargo clippy --all -- -D warnings
Expand All @@ -32,24 +36,20 @@ jobs:
submodules: "true"
- run: rustup show
- uses: Swatinem/rust-cache@v2
- uses: actions/setup-python@v4
with:
python-version: '3.11'
# - name: "Unit tests"
# run: |
# RUSTFLAGS="-D warnings" cargo test
- name: "Test examples"
- name: Run Rust tests
run: |
RUSTFLAGS="-D warnings" cargo run --example run_program
RUSTFLAGS="-D warnings" cargo test

udeps:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: "true"
- run: rustup toolchain install nightly --profile minimal
- uses: Swatinem/rust-cache@v2
with:
cache-on-failure: true
- run: cargo install cargo-udeps --locked
# - run: cargo +nightly udeps --all-targets
- run: cargo +nightly udeps
- name: Run udeps
run: cargo +nightly udeps --all-targets
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
[submodule "dependencies/cairo-lang"]
path = dependencies/cairo-lang
url = https://github.com/starkware-libs/cairo-lang
[submodule "test-programs"]
path = dependencies/test-programs
url = https://github.com/Moonsong-Labs/cairo-programs
5 changes: 3 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ edition = "2021"
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
cairo-vm = { git = "https://github.com/lambdaclass/cairo-vm", rev = "05352b1c67859a4d8cd128575c1e68ca7e300341", features = ["extensive_hints"] }
cairo-vm = { git = "https://github.com/lambdaclass/cairo-vm", rev = "05352b1c67859a4d8cd128575c1e68ca7e300341", features = [
"extensive_hints",
] }
whichqua marked this conversation as resolved.
Show resolved Hide resolved
num-traits = "0.2.19"
serde = { version = "1.0.202", features = ["derive"] }
serde_json = "1.0.117"
Expand All @@ -18,4 +20,3 @@ thiserror-no-std = "2.0.2"
[dev-dependencies]
assert_matches = "1.5.0"
rstest = "0.19.0"

whichqua marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion dependencies/cairo-lang
Submodule cairo-lang updated 225 files
1 change: 1 addition & 0 deletions dependencies/test-programs
Submodule test-programs added at b3a798
Loading