Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨tabs底部条颜色支持自由设置 #782

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zclghub
Copy link

@zclghub zclghub commented Dec 12, 2024

🤔 这个 PR 的性质是?(至少选择一个)

  • 日常 bug 修复
  • 新特性提交
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • CI/CD 改进
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

1.使tabs的底部条可以自由设置颜色,不再局限于使用单一颜色
2.tabs 增加lineBgColor属性,需要修改颜色时将颜色值传给lineBgColor即可
3.image

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充

Summary by CodeRabbit

  • 新功能

    • 更新了 wd-tabs 组件的文档,添加了多个新属性,包括 badge-propsauto-line-widthstickyslidabledisabledswipeableanimated
    • 新增 lineBgColor 属性,允许用户自定义标签底部线条的颜色。
    • 引入 updateLineStyle 方法,以支持在弹出上下文中更新活动标签的样式。
  • 文档

    • 更新了 wd-tabs 组件的使用说明和方法部分,提供了更清晰的指导。

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wot-design-uni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 6:14am

Copy link

coderabbitai bot commented Dec 12, 2024

Walkthrough

此次更改涉及对 wd-tabs 组件的文档和实现的更新,新增了多个属性和方法以增强组件的功能。主要更新包括为 wd-tab 添加 badge-props 属性、为 wd-tabs 添加 auto-line-widthstickyslidabledisabledswipeableanimated 属性。此外,还引入了 updateLineStyle 方法以更新活动标签的样式。这些更改旨在提升组件的可用性和灵活性。

Changes

文件路径 更改摘要
docs/component/tabs.md 更新文档以包括新特性和属性,详细描述 badge-propsauto-line-widthstickyslidabledisabledswipeableanimated 属性及 updateLineStyle 方法。
src/uni_modules/wot-design-uni/components/wd-tabs/types.ts tabsProps 中新增 lineBgColor 属性,用于指定标签底部线条的颜色。
src/uni_modules/wot-design-uni/components/wd-tabs/wd-tabs.vue wd-tabs 组件中新增 lineBgColor 属性,更新 updateLineStyle 函数以使用该属性,并在模板中添加 wd-badgecustom-class 属性。

Possibly related PRs

Suggested reviewers

  • Moonofweisheng

Poem

在标签间跳跃如风,
新属性让功能更丰。
颜色、动画随心调,
交互体验乐无穷。
兔子欢呼,变化多,
让我们一起乐陶陶! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for wot-design-uni ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 04486a3
🔍 Latest deploy log https://app.netlify.com/sites/wot-design-uni/deploys/675a7ee07ca8a90008fa73ae
😎 Deploy Preview https://deploy-preview-782--wot-design-uni.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)
docs/component/tabs.md (1)

266-266: 建议添加使用示例

文档中已经清晰地说明了 lineBgColor 属性的功能,但建议添加一个具体的使用示例,以帮助开发者更好地理解如何自定义底部条的颜色。

示例代码可以是:

<wd-tabs v-model="tab" lineBgColor="#ff0000">
  <wd-tab v-for="item in 4" :key="item" :title="`标签${item}`">
    <view class="content">内容{{ item }}</view>
  </wd-tab>
</wd-tabs>
src/uni_modules/wot-design-uni/components/wd-tabs/wd-tabs.vue (2)

323-325: 优化 lineBgColor 的应用方式

当前实现中使用 addUnit 处理 lineBgColor 是不必要的,因为颜色值不需要单位转换。建议直接使用颜色值:

-      lineStyle.background = addUnit(lineBgColor)
+      lineStyle.background = lineBgColor

311-312: 建议优化错误处理

在解构 props 时,建议使用更具体的错误处理,以便于定位问题:

   const { autoLineWidth, lineWidth, lineHeight, lineBgColor } = props
   try {
+    if (lineBgColor && !/^#([0-9A-Fa-f]{3}){1,2}$|^rgb\(.*\)$|^rgba\(.*\)$/.test(lineBgColor)) {
+      console.warn('[wot design] warning(wd-tabs): lineBgColor should be a valid color value')
+    }
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between be324c9 and 04486a3.

📒 Files selected for processing (3)
  • docs/component/tabs.md (1 hunks)
  • src/uni_modules/wot-design-uni/components/wd-tabs/types.ts (1 hunks)
  • src/uni_modules/wot-design-uni/components/wd-tabs/wd-tabs.vue (2 hunks)
🔇 Additional comments (1)
src/uni_modules/wot-design-uni/components/wd-tabs/types.ts (1)

62-65: 类型定义正确且符合最佳实践!

lineBgColor 属性的类型定义使用 makeStringProp('') 符合组件库的约定。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant