Skip to content

Commit

Permalink
Remove legacy ui test files (comfyanonymous#4316)
Browse files Browse the repository at this point in the history
  • Loading branch information
huchenlei authored Aug 15, 2024
1 parent f1d6cef commit ab4dd19
Show file tree
Hide file tree
Showing 19 changed files with 1 addition and 8,564 deletions.
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
# This is a temporary action during frontend TS migration.
# This file should be removed after TS migration is completed.
# The browser test is here to ensure TS repo is working the same way as the
# current JS code.
# If you are adding UI feature, please sync your changes to the TS repo:
# huchenlei/ComfyUI_frontend and update test expectation files accordingly.
name: Playwright Browser Tests CI
name: Test server launches without errors

on:
push:
Expand All @@ -21,15 +15,6 @@ jobs:
with:
repository: "comfyanonymous/ComfyUI"
path: "ComfyUI"
- name: Checkout ComfyUI_frontend
uses: actions/checkout@v4
with:
repository: "huchenlei/ComfyUI_frontend"
path: "ComfyUI_frontend"
ref: "fcc54d803e5b6a9b08a462a1d94899318c96dcbb"
- uses: actions/setup-node@v3
with:
node-version: lts/*
- uses: actions/setup-python@v4
with:
python-version: '3.8'
Expand All @@ -45,29 +30,13 @@ jobs:
python main.py --cpu 2>&1 | tee console_output.log &
wait-for-it --service 127.0.0.1:8188 -t 600
working-directory: ComfyUI
- name: Install ComfyUI_frontend dependencies
run: |
npm ci
working-directory: ComfyUI_frontend
- name: Install Playwright Browsers
run: npx playwright install --with-deps
working-directory: ComfyUI_frontend
- name: Run Playwright tests
run: npx playwright test
working-directory: ComfyUI_frontend
- name: Check for unhandled exceptions in server log
run: |
if grep -qE "Exception|Error" console_output.log; then
echo "Unhandled exception/error found in server log."
exit 1
fi
working-directory: ComfyUI
- uses: actions/upload-artifact@v4
if: always()
with:
name: playwright-report
path: ComfyUI_frontend/playwright-report/
retention-days: 30
- uses: actions/upload-artifact@v4
if: always()
with:
Expand Down
30 changes: 0 additions & 30 deletions .github/workflows/test-ui.yaml

This file was deleted.

1 change: 0 additions & 1 deletion tests-ui/.gitignore

This file was deleted.

9 changes: 0 additions & 9 deletions tests-ui/afterSetup.js

This file was deleted.

4 changes: 0 additions & 4 deletions tests-ui/babel.config.json

This file was deleted.

14 changes: 0 additions & 14 deletions tests-ui/globalSetup.js

This file was deleted.

11 changes: 0 additions & 11 deletions tests-ui/jest.config.js

This file was deleted.

Loading

0 comments on commit ab4dd19

Please sign in to comment.