Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add charge embedding #15

Merged
merged 3 commits into from
Apr 24, 2024
Merged

add charge embedding #15

merged 3 commits into from
Apr 24, 2024

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Apr 23, 2024

there's a partial embedding test that'll fail b/c incomplete.

  • add charge_embedding part of the schema, store on Mol
    • let the qcengine computer run it through psi4 since not standardized in qcengine and per-qc-prog
    • add a basic test for it
    • fix its output and qcvars
  • broaden tests to include heterogenous fragments (different elements, different frag lengths) and charges on fragments and (on my side) beyond energies

@loriab loriab marked this pull request as draft April 23, 2024 08:02
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Merging #15 (d7c2527) into main (b8f0645) will increase coverage by 1.80%.
Report is 13 commits behind head on main.
The diff coverage is 71.84%.

Additional details and impacted files

@loriab loriab marked this pull request as ready for review April 23, 2024 21:47
@loriab loriab merged commit 8c3c0a3 into MolSSI:main Apr 24, 2024
5 checks passed
@loriab loriab deleted the chgembed2 branch April 24, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant