Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jorge DZP-ZORA & TZP-ZORA #327

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Add Jorge DZP-ZORA & TZP-ZORA #327

merged 5 commits into from
Dec 12, 2024

Conversation

bennybp
Copy link
Member

@bennybp bennybp commented Dec 3, 2024

Adds:

  • DZP-ZORA: All-electron double zeta valence quality plus polarization functions (ZORA)
  • TZP-ZORA: All-electron triple zeta valence quality plus polarization functions (ZORA)

"role": "orbital",
"function_types": [
"gto",
"gto_cartesian"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks odd, I think these should be spherical. I don't see the sources in the basis_set_exchange-historical repo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can double check the paper. The basis sets emailed to me were in nwchem format and missing SPHERICAL in the top line. I would assume they are spherical too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they used NWChem, then the sets are cartesian...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimming the papers, looks like they used ORCA for the calculations, but they sent the basis sets in NWChem format. Some of their previous basis sets were also Gaussian format.

@susilehtola
Copy link
Contributor

These sets derive from the non-relativistic sets which are seriously wrong since the ROHF calculations failed silently for some atoms.

Using non-relativistic exponents is also wrong since relativity has significant effects on the primitives, as evinced by the Dyall sets, for instance...

@bennybp
Copy link
Member Author

bennybp commented Dec 4, 2024

Some of the tests failed because we actually do already have some elements of the TZP-ZORA basis, just not following the usual naming convention for the jorge family.

So I force pushed a new version. This adds the new elements to TZP-ZORA, and renames (A)TZP-ZORA to jorge-(A)TZP-ZORA (keeping the previous name as an alias).

@bennybp bennybp merged commit 5a1fd90 into master Dec 12, 2024
20 checks passed
@bennybp bennybp deleted the jzora branch December 12, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants