Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include positronic basis sets of Moncada et al #312

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

susilehtola
Copy link
Contributor

Basis sets from Chem. Sci. 11, 44 (2020)

@susilehtola
Copy link
Contributor Author

@bennybp good to merge

@bennybp
Copy link
Member

bennybp commented Jul 29, 2024

Just making sure I understand how these are constructed:

From the SI:
image

For the PsX-DZ dataset, alpha = 0.0190 and beta = 2.734. So by my reading the exponents should be 0.0190, 0.051946, 0.14202036 ...

But in your reference file they are 0.0190, 0.02443167421, 0.03141614235, ...

Seems like in the test files they are actually alpha * beta^(i/(n_l-1)) ?

@susilehtola
Copy link
Contributor Author

Damn, good catch. Yes, there was a typo in the script in the historical repo; I copy-pasted the script from the epc-8s8p8d basis where the arguments were different in that beta wasn't given, only the minimum and maximum exponent. Fixed

@susilehtola
Copy link
Contributor Author

@bennybp any reason why this has been sitting for 3 months without a merge?

@bennybp bennybp merged commit dbc1316 into MolSSI-BSE:master Nov 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants