[release] v1.0.6 #282
Merged
[release] v1.0.6 #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MNG-21 : 미션 인증 시 문구 추가
MNG-21 : 미션 인증 문구 추가 API 문서 반영
MNG-22 : 진행 중 미션에서 인증여부까지 확인
MNG-22 : 반복미션 모아보기 인증 인원수 리턴 타입 변경
fix : 반복미션 모아보기 인증 인원수 리턴 타입 변경
MNG-22 : 미션 관련 스케쥴링 추가
MNG-20 feat: 모두의 인증 현황에 미션 인증 댓글 수 추가
|
앞으로 해야할거
|
minsu20
reviewed
May 13, 2024
| import java.util.Optional; | ||
|
|
||
| @Repository | ||
| public interface MissionArchiveRepository extends JpaRepository<MissionArchive, Long>,MissionArchiveCustomRepository { | ||
|
|
||
| @Query("select m from MissionArchive as m where m.member =:memberId" ) |
There was a problem hiding this comment.
이거는 후에 querydsl로 수정이 되는건가요? 아니면 수정이 이미 됐나요?
There was a problem hiding this comment.
후에 querydsl로 변경 하겠숩니다!
| @Service | ||
| @RequiredArgsConstructor | ||
| @Transactional | ||
| public class CreateMissionCommentUseCase { |
There was a problem hiding this comment.
이렇게 한 클래스에 너무 많은 책임이 있어서 고민이 많았는데 이런 경우 연쇄패턴을 적용하면 결합도를 낮출 수 있다고 하더라구요? 이거에 대해 고민 중입니다
minsu20
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입
개요
앱스토어 기준 v1.0.6 버전
변경 사항
코드 리뷰 시 참고 사항
테스트 결과