Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditional requirement on privacy and terms last_updated #693

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Oct 14, 2024

What problem does your proposal solve?

Fixes #677

privacy_last_updated and terms_last_updated became "REQUIRED" in v3.0 by mistake.

Indeed, it causes an inconsistency with privacy_url and terms_url which are "OPTIONAL" values.

What is the proposal?

Make privacy_last_updated and terms_last_updated "Conditionally REQUIRED" again.

Is this a breaking change?

  • Yes
  • No
  • Unsure

Which files are affected by this change?

system_information.json

Thank you @hbruch for raising this issue 🙏

@richfab
Copy link
Contributor Author

richfab commented Oct 21, 2024

I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on Wednesday, October 30, 2024.
Please vote for or against the proposal, and include the organization for which you are voting in your comment.
Please note if you can commit to implementing the proposal.

@richfab richfab added Vote open v3.1-RC2 Candidate change for v3.1 (minor release) - 2nd pass labels Oct 21, 2024
@futuretap
Copy link
Contributor

+1

@tdelmas
Copy link
Contributor

tdelmas commented Oct 21, 2024

+1 for Fluctuo

@cmonagle
Copy link
Contributor

+1 for Transit

@testower
Copy link
Contributor

+1 for Entur

@richfab richfab removed the v3.1-RC2 Candidate change for v3.1 (minor release) - 2nd pass label Oct 23, 2024
@richfab
Copy link
Contributor Author

richfab commented Oct 28, 2024

💁 Voting on this PR closes in 2 calendar days.
Please vote for or against the proposal before 11:59PM UTC on Wednesday, October 30, 2024, and include the organization for which you are voting in your comment.
Please note if you can commit to implementing the proposal.

@richfab richfab added Vote Closing Soon v3.1-RC2 Candidate change for v3.1 (minor release) - 2nd pass and removed Vote open labels Oct 28, 2024
@richfab
Copy link
Contributor Author

richfab commented Nov 6, 2024

This vote has now closed, and it passes!

Votes in favor:

  • Where To? / FutureTap (consumer)
  • Fluctuo (consumer)
  • Transit (consumer)
  • Entur (producer)

There were no votes against.

This change will be part of v3.1-RC2, planned to be released this month (Nov 2024), as per the version release cycle in the governance.

Thank you for your involvement in the GBFS spec 🙏

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richfab richfab added v3.1-RC2 Candidate change for v3.1 (minor release) - 2nd pass and removed v3.1-RC2 Candidate change for v3.1 (minor release) - 2nd pass labels Nov 7, 2024
@richfab
Copy link
Contributor Author

richfab commented Nov 7, 2024

In order to fix this inconsistency in the spec due to a typo as soon as possible, the change will be applied directly to master.

Note that the JSON schemas for v3.0 and v3.1-RC are not affected by the typo. Which means they don't need to be updated and neither do the validator and the models since they are based on the JSON schemas.

@richfab richfab merged commit 9bd190d into master Nov 7, 2024
1 check passed
@richfab richfab deleted the privacy-terms-last-updated branch November 7, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch privacy_last_updated and terms_last_updated REQUIRED vs corresponding urls OPTIONAL
6 participants