-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conditional requirement on privacy and terms last_updated #693
Conversation
I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on Wednesday, October 30, 2024. |
+1 |
+1 for Fluctuo |
+1 for Transit |
+1 for Entur |
💁 Voting on this PR closes in 2 calendar days. |
This vote has now closed, and it passes! Votes in favor:
There were no votes against. This change will be part of v3.1-RC2, planned to be released this month (Nov 2024), as per the version release cycle in the governance. Thank you for your involvement in the GBFS spec 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In order to fix this inconsistency in the spec due to a typo as soon as possible, the change will be applied directly to master. Note that the JSON schemas for v3.0 and v3.1-RC are not affected by the typo. Which means they don't need to be updated and neither do the validator and the models since they are based on the JSON schemas. |
What problem does your proposal solve?
Fixes #677
privacy_last_updated
andterms_last_updated
became "REQUIRED" in v3.0 by mistake.Indeed, it causes an inconsistency with
privacy_url
andterms_url
which are "OPTIONAL" values.What is the proposal?
Make
privacy_last_updated
andterms_last_updated
"Conditionally REQUIRED" again.Is this a breaking change?
Which files are affected by this change?
system_information.json
Thank you @hbruch for raising this issue 🙏