Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate Voi's System ID in systems.csv #670

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Jul 31, 2024

Problem

The System ID was 'voiscooters.com' for the 2 Voi's feeds in system.csv, which is not conform to the GBFS specification:

It is up to the publisher of the feed to guarantee uniqueness and MUST be checked against existing system_id fields in systems.csv to ensure this.

What's Changed

  • 1 edit: updated the value of System ID in systems.csv for Voi Marseille to match the value of system_id in system_information.json after Voi updated it.
  • 1 removal: deleted the feed for Voi Brussels as it leads to a 403, as requested by @morten-skelmose from Voi.

Example:

Before After
voiscooters.com voi_Marseille

Contributors

Thank you @morten-skelmose for updating the system_id in the Voi's feeds 🙏

@richfab richfab merged commit 569cfcc into master Jul 31, 2024
1 check passed
@richfab richfab deleted the fix/update-voi-system-ids branch July 31, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants