Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove discontinued services with duplicate system_id #669

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Remove discontinued services with duplicate system_id #669

merged 1 commit into from
Jul 30, 2024

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Jul 30, 2024

Context

This PR is in preparation of #664 to add a column named ID in systems.csv.

What's Changed

This PR removes 3 discontinued services from systems.csv which caused duplicate System ID in systems.csv.

  • Razor Tempe ('system_id': 'razor'): discontinued in 2019 (source)
  • Razor Washington DC ('system_id': 'razor'): discontinued in 2020 (source)
  • Hopr Los Angeles ('system_id': '10'): free_bike_status.json is empty and station_status.json has only null values.

@richfab richfab requested a review from isabelle-dr July 30, 2024 08:41
@richfab richfab merged commit f2769bb into master Jul 30, 2024
1 check passed
@richfab richfab deleted the fix/remove-duplicate-system-ids-for-discontinued-services branch July 30, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelle-dr isabelle-dr isabelle-dr approved these changes

Assignees
No one assigned
Labels
systems.csv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richfab @isabelle-dr