Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate Neuron's System ID in systems.csv #668

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Jul 30, 2024

Context

This PR is in preparation of #664 to add a column named ID in systems.csv.

Problem

The System ID was always '11b14b88-3598-4d3c-821d-e6f2e37cd901' for all Neuron's feeds in system.csv.

What's Changed

This PR updates the value of System ID in systems.csv for 13 feeds from Neuron to match the value of system_id in system_information.json.

Neuron updated the system_id in system_information.json for all Neuron's feeds in system.csv to make them unique ids.

Example:

Before After
11b14b88-3598-4d3c-821d-e6f2e37cd901 neuron_ard
11b14b88-3598-4d3c-821d-e6f2e37cd901 neuron_bmt

Contributors

Thank you @gongmingqm10 for updating the system_id in the Neuron's feeds 🙏

@richfab richfab requested review from cka-y and isabelle-dr July 30, 2024 07:49
@richfab richfab merged commit c49c97b into master Jul 30, 2024
1 check passed
@richfab richfab deleted the fix/neuron-system-ids branch July 30, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants