Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate invalid System ID in systems.csv #666

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Jul 22, 2024

Context

This PR is in preparation of #664 to add a column named ID in systems.csv.

What's Changed

  • 7 edits: Updated the value of System ID in systems.csv for 7 feeds from LINK to match the value of system_id in system_information.json in the corresponding GBFS feed.
  • 16 deletions:
    • Removed 15 LINK systems as they shutdown operations in the U.S.
    • Removed a duplicate feed for Bicing Barcelona. Chose to keep the one with the correct value in the 'Name' column. The content of both feeds is identical. Only the URL slightly changes (both are from PBSC).

@richfab richfab requested review from cka-y and emmambd July 22, 2024 15:13
@mplsmitch
Copy link
Collaborator

As far as I know all of the US based LINK systems shutdown on Dec 31st, 2023 - unfortunately they did not stop publishing so it looks like these are now zombie feeds. When I look at free_bike_status, they're empty or nearly empty. I think this may also be true of the European LINK systems.

@richfab
Copy link
Contributor Author

richfab commented Jul 24, 2024

Thank you @mplsmitch. I removed all LINK feeds in the US.

Shutdown of LINK operations in the U.S. on Dec 31 2024 (TechCrunch).

@richfab richfab requested a review from isabelle-dr July 24, 2024 10:10
Copy link
Contributor

@isabelle-dr isabelle-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@richfab richfab merged commit ba28073 into master Jul 24, 2024
1 check passed
@richfab richfab deleted the fix/deduplicate-invalid-system-ids branch July 24, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants