-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify vehicle_id persistence rule #632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR: - Makes the rule about vehicle_id persistence more explicit: rotation is between rentals (not every time the feed is loaded) - Updates a forgotten reference to free_bike_status.json (now vehicle_status.json) Thanks @testower for flagging!
isabelle-dr
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
richfab
added a commit
to futuretap/gbfs
that referenced
this pull request
May 17, 2024
commit e0c48b2 Author: Fabien Richard-Allouard <[email protected]> Date: Mon Apr 29 11:13:47 2024 +0200 Clarify vehicle_id persistence rule (MobilityData#632) This PR: - Makes the rule about vehicle_id persistence more explicit: rotation is between rentals (not every time the feed is loaded) - Updates a forgotten reference to free_bike_status.json (now vehicle_status.json) Thanks @testower for flagging! commit 73d135d Author: Fabien Richard-Allouard <[email protected]> Date: Tue Apr 16 15:22:18 2024 +0200 Set the migration guide as the v3.0 Release Notes (MobilityData#628) This PR sets the migration guide article as the v3.0 Release Notes: https://mobilitydata.org/how-to-upgrade-to-gbfs-v3-0/ commit 457cb71 Author: Fabien Richard-Allouard <[email protected]> Date: Thu Apr 11 14:19:32 2024 +0200 Update current version to v3.0 (MobilityData#625) * Withdraw PR MobilityData#546 Floating Interval in price * Withdraw PR MobilityData#457 Reservation Price * Remove -RC and -RC2 from the spec * Update current version number in spec * Fix earlier version URLs * Update current version in README to v3.0 * Set version history URL to Release Notes commit f4dc269 Author: Mitch Vars <[email protected]> Date: Thu Apr 11 01:10:58 2024 -0500 Correction systems.csv (MobilityData#623) Fix missing csv comma commit 940cd63 Author: Mitch Vars <[email protected]> Date: Tue Apr 9 11:11:26 2024 -0500 Update systems.csv to remove dead feeds (MobilityData#622) * Update systems.csv Remove obsolete feeds * Update systems.csv * Add 4 feeds that now return status code 200 --------- Co-authored-by: Fabien Richard-Allouard <[email protected]> commit a77c5c2 Author: Fabien Richard-Allouard <[email protected]> Date: Tue Apr 9 15:40:21 2024 +0200 Mark system_hours and system_calendar as removed (MobilityData#621) ## Problem The files system_hours.json and system_calendar.json were removed in MobilityData#328. However, the spec says these files were “deprecated”, which usually means permitted, but discouraged. ## Solution Replace "deprecated” with "removed" for the files system_hours.json and system_calendar.json in the spec. commit 45e944a Author: indigotachizawa <[email protected]> Date: Mon Apr 8 21:01:42 2024 +0900 add new service 'kotobike' (MobilityData#620) commit 2f5aaad Author: Fabien Richard-Allouard <[email protected]> Date: Wed Mar 20 17:07:56 2024 +0100 Authentication information for Voi Brussels (MobilityData#613) This PR adds authentication information for Voi Brussels. > Access and usage of Voi’s GBFS data is subject to the following licensing terms: https://www.voi.com/voi-licencing-agreement. More info on the Belgium NAP: https://www.transportdata.be/dataset/voi commit a72d597 Author: Mitch Vars <[email protected]> Date: Wed Mar 13 12:03:36 2024 -0500 Update Nextbike URLs (MobilityData#610) * Update Nextbike URLs * Update 4 additional Nextbike URLs --------- Co-authored-by: Fabien Richard-Allouard <[email protected]> commit 4b4d3f7 Author: Fabien Richard-Allouard <[email protected]> Date: Wed Mar 13 14:31:38 2024 +0100 Fix FAQ URL in issue template (MobilityData#609) This PR fixes the FAQ URL in the issue template. Before | After -- | -- https://gbfs.mobilitydata.org/faq | https://gbfs.org/learn/faq/ commit b286e95 Author: Fabien Richard-Allouard <[email protected]> Date: Fri Mar 1 17:06:20 2024 +0100 Update roadmap URL in README (MobilityData#605) This PR updates the roadmap URL in the README: - Before: Github wiki - After: https://portal.productboard.com/26qpteg4wct9px3jts94uqv8/tabs/99-planned commit bea68ce Author: Fabien Richard-Allouard <[email protected]> Date: Tue Feb 27 16:03:23 2024 +0100 Delete obselete feed Donkey Republic Barcelona (MobilityData#599) commit b9d8390 Author: Fabien Richard-Allouard <[email protected]> Date: Wed Feb 14 12:54:14 2024 +0100 Fix geofencing examples (MobilityData#595) * Remove overlapping polygon from example * Change rule to override global rules in example commit 6a9150c Author: Fabien Richard-Allouard <[email protected]> Date: Mon Jan 29 14:16:55 2024 +0100 Fix markdown formatting (MobilityData#596) This PR fixes the markdown formatting when governance.md is imported on https://gbfs.org/specification/process/ commit a3d68f6 Author: Fabien Richard-Allouard <[email protected]> Date: Thu Jan 25 17:08:37 2024 +0100 Syncs systems.csv with transport.data.gouv (MobilityData#593) * Syncs systems.csv with transport.data.gouv * Move public keys to Authentication Info column * Update Authentication Info description in README * Rephrase Authentication Info description in README commit 0775ee4 Author: Fabien Richard-Allouard <[email protected]> Date: Tue Jan 23 17:39:47 2024 +0100 Label global_rules field as added in v3.0-RC (MobilityData#594) This editorial change adds a missing label under the field `global_rules` to explain that the field was added in v3.0-RC. commit e9fc5aa Author: Ortwin Gentz, FutureTap <[email protected]> Date: Mon Jan 22 15:39:26 2024 +0100 gbfs.md: Fix language about iOS links (MobilityData#585) commit 411b4f4 Author: Fabien Richard-Allouard <[email protected]> Date: Mon Jan 15 15:44:59 2024 +0100 README.md: Add link to v2.3 Release Notes (MobilityData#592) This PR adds the link to the [v2.3 Release Notes](https://github.com/MobilityData/gbfs/releases/tag/v2.3) in the Current Version table of the [README.md](https://github.com/MobilityData/gbfs/blob/master/README.md). commit 32ccae4 Author: Fabien Richard-Allouard <[email protected]> Date: Mon Jan 15 15:00:59 2024 +0100 GBFS Governance Revisions (MobilityData#579) * Add release cycles to the governance * Link README to governance.md for Release Cycles * Simplify MINOR version release line * Update stale bot * Typo commit 4e9c72f Author: Merja Kajava <[email protected]> Date: Thu Jan 11 17:49:29 2024 +0200 Updated location names in systems.csv (MobilityData#590) commit 43b9be7 Author: Fabien Richard-Allouard <[email protected]> Date: Thu Jan 11 14:39:23 2024 +0100 Add country name when location is empty (MobilityData#589) commit 3806cdc Author: Merja Kajava <[email protected]> Date: Thu Jan 11 12:37:46 2024 +0200 Removed nextbike_fo from systems.csv (MobilityData#588) commit f6a9c56 Author: Fabien Richard-Allouard <[email protected]> Date: Wed Jan 10 16:54:59 2024 +0100 Location formatting recommendation in systems.csv (MobilityData#587) * Location formatting recommendation in systems.csv This PR adds a recommendation in README.md about the formatting of the system location in systems.csv. * Remove country code from formatting recommendation * Remove country code from Location column commit a36a103 Author: Fabien Richard-Allouard <[email protected]> Date: Wed Jan 10 14:52:57 2024 +0100 Update VéloZef (Brest, FR) system_id (MobilityData#586) This PR updates the system_id of VéloZef (Brest, FR) to match the system_id from the [feed](https://api.prod.partners-fs37hd8.zoov.eu/gbfs/2.2/brest/en/system_information.json?&key=OGNhZDNjMDQtYTA0Yi00NzU2LWE0MTItOGJlYzE1Y2E4NGEx): `velozef`. Thanks to @XioNoX for noticing ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Thanks @testower for flagging!