Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate uniqueness of values in Arrays of IDs #102

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Nov 17, 2023

Fixes #99

Example of vehicle_types.json file with with duplicate ids in the field vehicle_types.pricing_plan_ids:

"pricing_plan_ids": ["1-standard", "1-standard"]
Before After
image image

@richfab richfab linked an issue Nov 17, 2023 that may be closed by this pull request
@richfab richfab requested a review from isabelle-dr November 17, 2023 16:16
@qcdyx qcdyx self-requested a review November 20, 2023 19:48
Copy link

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richfab richfab merged commit b73b40f into master Nov 20, 2023
2 checks passed
@richfab richfab deleted the feat/unique-values-in-arrays-of-ids branch November 20, 2023 19:49
@richfab
Copy link
Contributor Author

richfab commented Nov 22, 2023

Reverting the validation of unique values in Arrays of IDs since this is a best practice, not explicitly written in the specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate uniqueness of values in Arrays of IDs
2 participants