Run Excel tests on Spark 3.5.3

MobileTeleSystems · Dec 5, 2024 · 1cc7fec · 1cc7fec
1 parent 81458ca
commit 1cc7fec
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/.github/workflows/data/local-fs/matrix.yml b/.github/workflows/data/local-fs/matrix.yml
@@ -20,8 +20,7 @@ min_excel: &min_excel
   os: ubuntu-latest
 
 max: &max
-  # Excel pagkage currently supports Spark 3.5.1 max
-  spark-version: 3.5.1
+  spark-version: 3.5.3
   pydantic-version: 2
   python-version: '3.12'
   java-version: 20

diff --git a/requirements/tests/spark-3.5.1.txt b/requirements/tests/spark-3.5.1.txt
diff --git a/tests/fixtures/spark.py b/tests/fixtures/spark.py
@@ -104,8 +104,17 @@ def maven_packages(request):
             packages.extend(MongoDB.get_packages(spark_version=str(pyspark_version)))
 
         if "excel" in markers:
-            # There is no Excel files support for Spark less than 3.2
-            packages.extend(Excel.get_packages(spark_version=str(pyspark_version)))
+            # There is no Excel files support for Spark less than 3.2.
+            # There are package versions only for specific Spark versions,
+            # see https://github.com/nightscape/spark-excel/issues/902
+            if pyspark_version.minor == 2:
+                packages.extend(Excel.get_packages(spark_version="3.2.4"))
+            elif pyspark_version.minor == 3:
+                packages.extend(Excel.get_packages(spark_version="3.3.4"))
+            elif pyspark_version.minor == 4:
+                packages.extend(Excel.get_packages(spark_version="3.4.3"))
+            elif pyspark_version.minor == 5:
+                packages.extend(Excel.get_packages(spark_version="3.5.1"))
 
     return packages