* fixed: ObjCProtocol to NSObject promoter in case of private classes and multiple constructors #753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
it fixes following case
causes compilation warning:
and runtime crash if this class is used as
NSObjectProtocol
withObjC
:Promoter was working only in case one constructor is present.
But in case of private classes there is additional synthetic public constructor is created. Code updated to ignore synthetic constructors and allow multiple constructors to be available
Inspection
Added Intellij Idea ispections to highlight following cases:
java.lang.Object
-- warning with quick fix to extend from NSObject (actually this class will be promoted)java.lang.Object
-- warning for both classes and quick fix to navigate to supper that can be updated with NSObject super.