@phenomic/plugin-transform-asciidoc: minor tweaks to adjust lint/tests

poke @ezralalonde :)
MoOx · Oct 11, 2017 · 15cbdf1 · 15cbdf1 · ezralalonde · Oct 11, 2017
1 parent 807f296
commit 15cbdf1
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 20 deletions.
diff --git a/packages/plugin-transform-asciidoc/package.json b/packages/plugin-transform-asciidoc/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@phenomic/plugin-transform-asciidoc",
-  "version": "1.0.0-alpha.10",
+  "version": "1.0.0-alpha.11",
   "publishConfig": {
     "access": "public"
   },

diff --git a/packages/plugin-transform-asciidoc/src/__tests__/__snapshots__/index.js.snap b/packages/plugin-transform-asciidoc/src/__tests__/__snapshots__/index.js.snap
@@ -39,7 +39,7 @@ Object {
 <div class=\\"listingblock\\">
 <div class=\\"content\\">
 <pre class=\\"highlight\\"><code class=\\"hljs language-javascript\\" data-lang=\\"javascript\\"><span class=\\"hljs-keyword\\">const</span> name = <span class=\\"hljs-string\\">\\"Ezra\\"</span>
-<span class=\\"hljs-built_in\\">console</span>.log(<span class=\\"hljs-string\\">\`Hello, nodejs!\`</span>)</code></pre>
+<span class=\\"hljs-built_in\\">console</span>.log(<span class=\\"hljs-string\\">\`Hello, <span class=\\"hljs-subst\\">\${name}</span>!\`</span>)</code></pre>
 </div>
 </div>
 </div>

diff --git a/packages/plugin-transform-asciidoc/src/__tests__/__snapshots__/transformer.js.snap b/packages/plugin-transform-asciidoc/src/__tests__/__snapshots__/transformer.js.snap
@@ -39,7 +39,7 @@ Object {
 <div class=\\"listingblock\\">
 <div class=\\"content\\">
 <pre class=\\"highlight\\"><code class=\\"hljs language-javascript\\" data-lang=\\"javascript\\"><span class=\\"hljs-keyword\\">const</span> name = <span class=\\"hljs-string\\">\\"Ezra\\"</span>
-<span class=\\"hljs-built_in\\">console</span>.log(<span class=\\"hljs-string\\">\`Hello, nodejs!\`</span>)</code></pre>
+<span class=\\"hljs-built_in\\">console</span>.log(<span class=\\"hljs-string\\">\`Hello, <span class=\\"hljs-subst\\">\${name}</span>!\`</span>)</code></pre>
 </div>
 </div>
 </div>
@@ -272,7 +272,17 @@ Object {
                             ".log(",
                             Object {
                               "c": Array [
-                                "\`Hello, nodejs!\`",
+                                "\`Hello, ",
+                                Object {
+                                  "c": Array [
+                                    "\${name}",
+                                  ],
+                                  "p": Object {
+                                    "className": "hljs-subst",
+                                  },
+                                  "t": "span",
+                                },
+                                "!\`",
                               ],
                               "p": Object {
                                 "className": "hljs-string",

diff --git a/packages/plugin-transform-asciidoc/src/__tests__/index.js b/packages/plugin-transform-asciidoc/src/__tests__/index.js
@@ -27,7 +27,7 @@ Test of Asciidoc.js transformer for Phenomic.
 
 [source,javascript]
 const name = "Ezra"
-console.log(\`Hello, ${name}!\`)
+console.log(\`Hello, \${name}!\`)
 `)
       })
   ).toMatchSnapshot();

diff --git a/packages/plugin-transform-asciidoc/src/__tests__/transformer.js b/packages/plugin-transform-asciidoc/src/__tests__/transformer.js
@@ -2,7 +2,7 @@ import defaultConfig from "@phenomic/core/lib/defaultConfig.js";
 
 import transformer from "../transformer.js";
 
-const input = `
+const input = new Buffer(`
 = Hello, AsciiDoc!
 Ezra Lalonde <[email protected]>
 v1.0, 2017-10-05: First Draft
@@ -18,8 +18,8 @@ Test of Asciidoc.js transformer for Phenomic.
 
 [source,javascript]
 const name = "Ezra"
-console.log(\`Hello, ${name}!\`)
-`;
+console.log(\`Hello, \${name}!\`)
+`);
 
 it("should render asciidoc as json (react component)", () => {
   const adoc = transformer(
@@ -40,55 +40,55 @@ it("should render asciidoc as html", () => {
 it("should have tags", () => {
   const adoc = transformer(
     defaultConfig,
-    `
+    new Buffer(`
 = Title
 :tags: phenomic, documentation, test, déjà vu
-  `
+  `)
   );
   expect(adoc.tags).toEqual(["phenomic", "documentation", "test", "deja-vu"]);
 });
 
 it("should not have tags", () => {
   const adoc = transformer(
     defaultConfig,
-    `
+    new Buffer(`
 = Title
-  `
+  `)
   );
   expect(adoc.tags).toEqual([]);
 });
 
 it("should use explicit date attribute for date", () => {
   const adoc = transformer(
     defaultConfig,
-    `
+    new Buffer(`
 = Title
 Ezra Lalonde <[email protected]>
 v1.0, 2017-10-05: First Draft
 :date: 2011-12-25
-  `
+  `)
   );
   expect(adoc.date).toBe("2011-12-25");
 });
 
 it("should use revdate for date", () => {
   const adoc = transformer(
     defaultConfig,
-    `
+    new Buffer(`
 = Title
 Ezra Lalonde <[email protected]>
 v1.0, 2017-10-05: First Draft
-  `
+  `)
   );
   expect(adoc.date).toBe("2017-10-05");
 });
 
 it("should use have no date attribute", () => {
   const adoc = transformer(
     defaultConfig,
-    `
+    new Buffer(`
 = Title
-  `
+  `)
   );
   expect(adoc.date).toBe(undefined);
 });
diff --git a/packages/plugin-transform-asciidoc/src/transformer.js b/packages/plugin-transform-asciidoc/src/transformer.js
@@ -54,7 +54,7 @@ const envAttributes = [
 function processAsciidoc(text) {
   const ad = asciidoctor();
   const doc = ad.load(text, defaultOptions);
-  let data = {
+  const data = {
     ...doc.attributes.$$smap,
     contents: ad.convert(text, defaultOptions)
   };
@@ -83,7 +83,7 @@ const createElement = (component, props, children) => {
   };
 };
 
-export default (config?: PhenomicConfig, contents: string) => {
+export default (config?: PhenomicConfig, contents: Buffer) => {
   const data = processAsciidoc(contents);
 
   const processor = unified()