feat!: Change yaml for Custom DNS definition + add custom.list template #285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Breaking change that will require a migration action from v2 to v3
Changed custom DNS YAML definition from:
to:
The fields are named to how they're named in the GUI.
I've moved the formatting of these lines to the configmap templates.
Additionally, I added a new configmap to generate the
custom.list
so the custom DNS entries show up in the GUI.Benefits
Custom DNS entries will show up in GUI, with the additional benefit of a better readable
values.yaml
Possible drawbacks
Will require users to edit their
values.yaml
when upgrading from v2 to v3Applicable issues
Checklist