Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Change yaml for Custom DNS definition + add custom.list template #285

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

xorinzor
Copy link

@xorinzor xorinzor commented Feb 18, 2024

Description of the change

Breaking change that will require a migration action from v2 to v3

Changed custom DNS YAML definition from:

dnsmasq.customCnameEntries:
- cname=cname.foo.bar,foo.bar
dnsmasq.customDnsEntries:
- address=/foo.bar/192.168.1.1

to:

dnsmasq.customCnameEntries:
- domain: cname.foo.bar
  target: foo.bar
dnsmasq.customDnsEntries:
- domain: foo.bar
  address: 192.168.1.1

The fields are named to how they're named in the GUI.

I've moved the formatting of these lines to the configmap templates.
Additionally, I added a new configmap to generate the custom.list so the custom DNS entries show up in the GUI.

Benefits

Custom DNS entries will show up in GUI, with the additional benefit of a better readable values.yaml

Possible drawbacks

Will require users to edit their values.yaml when upgrading from v2 to v3

Applicable issues

Checklist

@MoJo2600
Copy link
Owner

Thank you for your contribution. I like this change even if it is breaking the release. I will test it on my installation. There is another breaking change in the pipeline then I'll create one new release with both changes.

@MoJo2600 MoJo2600 changed the title feat: Change yaml for Custom DNS definition + add custom.list template feat!: Change yaml for Custom DNS definition + add custom.list template Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants