Removal: drop deprecated spec.loadBalancerIP
#216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerRockWolf
force-pushed
the
feature/loadBalancerIP-deprecation
branch
2 times, most recently
from
806b031
to
7753121
Compare
DerRockWolf
force-pushed
the
feature/loadBalancerIP-deprecation
branch
from
7753121
to
a1802c4
Compare
DerRockWolf
changed the title
loadBalancerIPspec.loadBalancerIP
|
After more than one and a half years I've stumbled upon my draft PR 😂 |
|
Hey, thank you again for your work. I'm working on a V2 of this chart in a private repo right now. Mainly I want to change the deployment and have some pipeline to release new pihole versions automatically. I'd love to merge the outstanding pull requests when this is finished and release a v2 of this chart asap. |
|
I merged the new deployment stuff right now. I do want to start working on V3 now. There is a branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec.loadBalancerIPis deprecated since v1.24 in favor of provider specific annotations (such asmetallb.universe.tf/loadBalancerIPsfor MetalLB)Docs: https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer
PR: kubernetes/kubernetes#107235
Fell free to adjust the version if you don't want major bumps for values removal.
FYI: You should somehow enforce the generation of the chart readme (
charts/pihole/README.md), as it was missing some previously added values!