Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to print text #25

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Add possibility to print text #25

merged 3 commits into from
Nov 21, 2023

Conversation

tiopex
Copy link
Contributor

@tiopex tiopex commented Nov 16, 2023

Add the possibility to print any string text to the console from uboot level. For demonstration purposes, print information about the autodetected device version. After the first run, information is not visible anymore.

@tiopex tiopex requested a review from Apaczer November 16, 2023 21:10
@nfriedly
Copy link
Member

  1. I'm glad this is here, it's absolutely better than what we had before. 100% ship it!
  2. Isn't this somewhat going about it the wrong way? Like, how does the boot process normally print text to the screen?

@tiopex
Copy link
Contributor Author

tiopex commented Nov 17, 2023

  1. Isn't this somewhat going about it the wrong way? Like, how does the boot process normally print text to the screen?

not in wrong way, but in a shortcut way. Normally should set allwinner PLL, DEBE, porchs, clocks etc... then create 320x240 framebuffer, and point it to DEBE. Here all this stuff is bypassed and written directly to LCD panel memory

Copy link
Member

@Apaczer Apaczer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be usefull for debug because till now I dont know how to grab uboot log msgs.

Does it reload screen buffer if there is no space left, or simply how much text you can fit in = that much can be generated?

drivers/video/sunxi/sunxi_display.c Outdated Show resolved Hide resolved
drivers/video/sunxi/sunxi_display.c Outdated Show resolved Hide resolved
drivers/video/sunxi/sunxi_display.c Outdated Show resolved Hide resolved
drivers/video/sunxi/lcd_font.h Outdated Show resolved Hide resolved
@tiopex
Copy link
Contributor Author

tiopex commented Nov 17, 2023

It could be usefull for debug because till now I dont know how to grab uboot log msgs.

Does it reload screen buffer if there is no space left, or simply how much text you can fit in = that much can be generated?

if current x/y is bigger than display width/height it back x/y to 0, so basically start writing from the beginning of the panel

@Apaczer
Copy link
Member

Apaczer commented Nov 18, 2023

if current x/y is bigger than display width/height it back x/y to 0, so basically start writing from the beginning of the panel

Then I suggest to fill LCD panel with black before displaying any text and after "y" is filled - like normally you would have on tty

Copy link
Member

@Apaczer Apaczer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah 8x12 looks much better also lcdFillBgColor() works as requested. Thanks, this will come in handy.

@tiopex tiopex merged commit 36d4863 into MiyooCFW:master Nov 21, 2023
2 checks passed
tiopex added a commit that referenced this pull request Nov 22, 2023
---------

Co-authored-by: tiopex <[email protected]>
Co-authored-by: Apaczer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants