Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant Iter #22

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Remove redundant Iter #22

merged 2 commits into from
Feb 4, 2024

Conversation

Maneren
Copy link
Contributor

@Maneren Maneren commented Feb 4, 2024

Removes the DefaultDictIter in favor of using the Iter from std.

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (23b4b72) 97.83% compared to head (bd16a6c) 97.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   97.83%   97.62%   -0.21%     
==========================================
  Files           2        2              
  Lines         323      295      -28     
==========================================
- Hits          316      288      -28     
  Misses          7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MitchellBerend
Copy link
Owner

I "stole" your implementation and applied it to DefaultBTreeMap as well.

Thanks for this contribution as well.

@MitchellBerend MitchellBerend merged commit c4e8780 into MitchellBerend:master Feb 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants