Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doxygen Workflow #34

Open
wants to merge 16 commits into
base: development
Choose a base branch
from
Open

Doxygen Workflow #34

wants to merge 16 commits into from

Conversation

three-halves
Copy link
Contributor

Adds a Doxyfile, some resources to be used by Doxygen, and a github workflow file to automatically generate human-readable documentation similar to the Autonomy_Software repo.

@three-halves three-halves requested a review from a team as a code owner November 28, 2024 03:00

DateTime start = DateTime.Now;
RoveCommService.Ping(board);
var response = await RoveCommService.Listen<int>(RoveCommManifest.SystemPackets.PING_REPLY);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive that you figured out a way to do rovecomm pings without me actually providing a way to do it in the rovecomm API. Note that this will break if you

  1. click "Rove" for CoreBoard
  2. click "Rove" for PMS
  3. PMS responds first
  4. now RovePingBoard() for both CoreBoard and PMS return successfully because a PING_REPLY arrived
  5. CoreBoard itself never actually responds
    This is fine though since I don't think we ever use the Rove ping lol.
    Maybe in the future, I'll give RoveComm a RovePingResponse response = await RoveCommService.PingAsync(board) API where RovePingResponse tells you what board gave the PING_REPLY

Copy link
Contributor

@OcelotEmpire OcelotEmpire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool and good

We'll have to fix RovePingBoard in the future but it's fine for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants