Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: class names #4

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix: class names #4

merged 1 commit into from
Jul 11, 2024

Conversation

FedeIlLeone
Copy link
Contributor

  • Fixed class names of ShowOriginalLink, ImageLink and AvatarDecorationCheckmark.
  • Added the AvatarDecorationCheckmark to the nicknames on the new profiles.

Reporting two bugs I didn't fix, it would require some more work:

  • AvatarDecorationCheckmark has a bug with new profiles where the checkmark is being applied on activities. This is due to how the checkmark is applied to DMs.
  • ProfileBannerHeight has some wrong class names, I didn't update them because something would have to be redone with the new profiles regardless since it's position is moved in the wrong place. This snippet also has the customization settings are in scss in the readme, which the mod editors do not accept.

Copy link
Member

@Saltssaumure Saltssaumure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Saltssaumure Saltssaumure merged commit 15a92e9 into MiniDiscordThemes:main Jul 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants