Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exploding values #18

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

roeezis
Copy link

@roeezis roeezis commented Mar 24, 2021

Fix non convergence of the local smoothing filter iterations, as sdot(d,q) would be Infinity for large numbers, eventually resulting in NaN rnorm.
the fix changes float to 64bit double precision for scalars, sdot and saxpy calculations.

Fix non-converging local smoothing filter (with eventual NaN rnorm)
Fix non convergence of the local smoothing filter iterations, eventually resulting in NaN rnorm
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #18 (d729f43) into master (d8ec668) will decrease coverage by 0.00%.
The diff coverage is 29.26%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #18      +/-   ##
============================================
- Coverage     40.85%   40.85%   -0.01%     
- Complexity     7221     7222       +1     
============================================
  Files           264      264              
  Lines         63167    63167              
  Branches      10299    10299              
============================================
- Hits          25809    25806       -3     
- Misses        35659    35663       +4     
+ Partials       1699     1698       -1     
Impacted Files Coverage Δ Complexity Δ
...n/java/edu/mines/jtk/dsp/LocalSmoothingFilter.java 25.17% <29.26%> (ø) 19.00 <0.00> (ø)
core/src/main/java/edu/mines/jtk/mesh/TriMesh.java 60.83% <0.00%> (-0.23%) 244.00% <0.00%> (ø%)
core/src/main/java/edu/mines/jtk/mesh/TetMesh.java 51.43% <0.00%> (ø) 388.00% <0.00%> (ø%)
...n/java/edu/mines/jtk/interp/CubicInterpolator.java 72.41% <0.00%> (+0.43%) 51.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ec668...d729f43. Read the comment docs.

add a newline at the end of the .gitignore file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant