fix: Demo project cleanup #87
Conversation
miquelbeltran
requested review from
TheRealAgentK,
sumitramanga,
a team and
PanosNB
and removed request for
a team
|
|
||
| Install with `npm install -g npx` if not present already in your system. |
There was a problem hiding this comment.
npx should come with npm if npm is already installed :-)
There was a problem hiding this comment.
Ok, added it just in case, I wasn't sure if npx was set up automatically when installing npm.
There was a problem hiding this comment.
Yeah it is these days, last 3-4 years or so?
| - name: Setup Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '20' |
There was a problem hiding this comment.
This is Node.js, right? Perhaps we use the latest stable version of node ? If that's moving away from the general goa of this PR, we can leave it
There was a problem hiding this comment.
This is needed to setup npm on Github actions, not as much important to run the actual project, but just to have npm present when testing the project in GitHub.
|
|
||
| /** | ||
| * Run Proguard to shrink the Java bytecode in release builds. | ||
| * Set this to true to Run Proguard on Release builds to minify the Java bytecode. | ||
| */ | ||
| def enableProguardInReleaseBuilds = false |
There was a problem hiding this comment.
This is a react-specific setting, I think?
Is that also taking care of R8?
There was a problem hiding this comment.
This was generated by the RN create command, haven't looked into it.
I only had to add the jettifier to true due to some 3rd party dependencies not supporting AndroidX libraries.
fix: Demo project cleanup
Description 📝
Type of change
Updates
demoproject usingnpx react-native init..gitignoreand similar files.Screenshots 📷
Android Emulator screenshot:
iOS simulator screenshot:
Test plan 🧪
Author to check 👓
Reviewer to check ✔️