Remove dependency from mina_numbers from compile config #15022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
|
!ci-nightly-me |
This was referenced Feb 2, 2024
mrmr1993
approved these changes
Feb 2, 2024
georgeee
approved these changes
Feb 2, 2024
|
!ci-build-me |
mrmr1993
added a commit
that referenced
this pull request
Feb 20, 2024
…onconsensus-dependencies-develop Merge #15022 into develop
mrmr1993
added a commit
that referenced
this pull request
Feb 20, 2024
…onconsensus-dependencies-berkeley Merge #15022 into berkeley
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14516 introduced a dependency on
mina_numbersformina_compile_config. This broke the build ofsrc/nonconsensus(see https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/1273#018d686f-508b-4630-b49e-3dddd6ee9e7d).This PR removes that dependency by making the parameters
intand delegation toruntime_configthe conversion toGlobal_slot.t, as it happens already in other branches.