Skip to content

Commit

Permalink
Merge branch 'PVW-3641-update-mapping-docs' into 'main'
Browse files Browse the repository at this point in the history 
PVW-3641: Update mapping docs

See merge request wallet/nl-wallet!1297
  • Loading branch information
@rubin55
rubin55 committed Oct 25, 2024
2 parents 617059d + 7fe7e43 commit 998edd7
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 27 deletions.
2 changes: 0 additions & 2 deletions documentation/api/wallet-disclosure-components.openapi.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ components:
properties:
given_name: boolean
family_name: boolean
own_family_name: boolean
given_name_birth: boolean
family_name_birth: boolean
gender: boolean
Expand All @@ -52,7 +51,6 @@ components:
birth_city: boolean
birth_state: boolean
birth_country: boolean
has_spouse_or_partner: boolean
bsn: boolean
additionalProperties: false
com.example.address:
Expand Down
48 changes: 23 additions & 25 deletions documentation/relying-party.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -129,36 +129,34 @@ can verify. For your convenience, we list the attributes for both doctypes here:

### What a PID_DOCTYPE looks like

| Attribute | Description |
|--------------------|---------------------------------------------------------|
| given_name | First names (voornamen) |
| family_name_prefix | Prefix (voorvoegsel) |
| family_name | Surname (achternaam) |
| given_name_birth | First names at birth (voornamen bij geboorte) |
| family_name_birth | Birth name (geboortenaam) |
| gender | Gender (geslacht) |
| birth_date | Birth date (geboortedatum) |
| age_over_18 | Older than 18 (ouder dan 18) |
| birth_place | Place of birth (geboorteplaats) **\*** |
| birth_city | City, town or village of birth (geboortestad) |
| birth_state | State or province of birth (geboortestaat of -provincie)|
| birth_country | Country of birth (geboorteland) |
| bsn | Citizen service number (burgerservicenummer) |
| nationality | Nationality (nationaliteit) |
| Attribute | Item | Source | Description |
|-----------------------|--------------|---------------|----------------------------------------------------------|
| given_name | 10210 | haal_centraal | First names (voornamen) |
| family_name | 10230, 10240 | haal_centraal | Prefix (voorvoegsel) and surname (achternaam) |
| given_name_birth | | unimplemented | First names at birth (voornamen bij geboorte) |
| family_name_birth | | unimplemented | Birth name (geboortenaam) |
| gender | | unimplemented | Gender (geslacht) |
| birth_date | 10310 | haal_centraal | Birth date (geboortedatum) |
| age_over_18 | | derived | Older than 18 (ouder dan 18) |
| birth_place | | unimplemented | Place of birth (geboorteplaats) **\*** |
| birth_city | | unimplemented | City, town or village of birth (geboortestad) |
| birth_state | | unimplemented | State or province of birth (geboortestaat of -provincie) |
| birth_country | | unimplemented | Country of birth (geboorteland) |
| bsn | 10120 | haal_centraal | Citizen service number (burgerservicenummer) |

*\* birth_place is a combination of birth_country, birth_state and birth_city*

### What an ADDRESS_DOCTYPE looks like

| Attribute | Description |
|-----------------------|----------------------------------------|
| resident_address | Address (adres) **\*** |
| resident_street | Street name (straatnaam) |
| resident_house_number | House number (huisnummer) |
| resident_postal_code | Postal code (postcode) |
| resident_city | City, town or village (woonplaats) |
| resident_state | State or province (staat of provincie) |
| resident_country | Country (land) |
| Attribute | Item | Source | Description |
|-----------------------|---------------------|---------------|-----------------------------------------------------------------------|
| resident_address | | unimplemented | Address (adres) **\*** |
| resident_street | 81115, 81110 | haal_centraal | Named public space (naam openbare ruimte) or street name (straatnaam) |
| resident_house_number | 81120, 81130, 81140 | haal_centraal | House number (huisnummer) |
| resident_postal_code | 81160 | haal_centraal | Postal code (postcode) |
| resident_city | 81170 | haal_centraal | City, town or village (woonplaats) |
| resident_state | | unimplemented | State or province (staat of provincie) |
| resident_country | | unimplemented | Country (land) |

*\* resident_address is a combination of resident_ street, house_number, postal_code, city, state and country*

Expand Down
2 changes: 2 additions & 0 deletions wallet_core/gba_hc_converter/src/haal_centraal.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,10 @@ pub enum Element {
Huisnummer = 1120,
Huisletter = 1130,
Huisnummertoevoeging = 1140,
// TODO: we currently request <ns0:item>81150</ns0:item>, but don't map here; remove or add here?
Postcode = 1160,
Woonplaats = 1170,
// TODO: we currently request <ns0:item>81210</ns0:item>, but don't map here; remove or add here?
SoortVerbintenis = 1510,
IndicatieNaamgebruik = 6110,
RedenOpnameNationaliteit = 6310,
Expand Down

0 comments on commit 998edd7

Please sign in to comment.