Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Петров, 5, 15, 16, 17 #69

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Петров, 5, 15, 16, 17 #69

wants to merge 25 commits into from

Conversation

fromfall
Copy link
Contributor

@fromfall fromfall commented Nov 1, 2015

No description provided.

@fromfall fromfall changed the title Петров, 10, 11 Петров, 9, 10, 11 Nov 13, 2015
MikhailErofeev
MikhailErofeev reviewed Nov 15, 2015
View reviewed changes
lab9/lab9.py
left = mid + 1


def test():
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тесты в отдельном файле с помощью unittest, пожалуйста
и консольный интерфейс сделайте, пожалуйста, к каждой реализации.

@MikhailErofeev
Copy link
Owner

9 надо поправить
10, 11 ок

@fromfall fromfall mentioned this pull request Nov 15, 2015
Merged
@fromfall fromfall changed the title Петров, 9, 10, 11 Петров, 9, 10, 11, 14, 18 Dec 12, 2015
@fromfall fromfall changed the title Петров, 9, 10, 11, 14, 18 Петров, 9, 10, 11, 14, 18, 19 Dec 12, 2015
@fromfall
Copy link
Contributor Author

Задача №20. CF: http://codeforces.com/contest/525/submission/14836679

@fromfall fromfall changed the title Петров, 9, 10, 11, 14, 18, 19 Петров, 9, 10, 11, 14, 18, 19, 20 Dec 16, 2015
@fromfall fromfall changed the title Петров, 9, 10, 11, 14, 18, 19, 20 Петров, 9, 14, 18, 19, 20 Dec 16, 2015
MikhailErofeev
MikhailErofeev reviewed Dec 20, 2015
View reviewed changes
lab18/lab18.py
if len(a) < len(b):
a, b = b, a
x = [[], [], []]
global i_shift
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global плохо использовать, из-за изменяемого состояния где-то сбоку понимание кода усложняется
плохой нейминг

@MikhailErofeev
Copy link
Owner

9+
14+
18+
19+
20+

разрулите, пожалуйста, мерж конфликт

@fromfall fromfall changed the title Петров, 9, 14, 18, 19, 20 Петров, 5 Dec 21, 2015
@fromfall
Copy link
Contributor Author

Апдейт 5 задачи с другого PR.

@fromfall fromfall changed the title Петров, 5 Петров, 5, 17 Dec 21, 2015
@fromfall fromfall changed the title Петров, 5, 17 Петров, 5, 16, 17 Dec 22, 2015
@fromfall fromfall changed the title Петров, 5, 16, 17 Петров, 5, 15, 16, 17 Dec 23, 2015
MikhailErofeev
MikhailErofeev reviewed Dec 25, 2015
View reviewed changes
lab16/lab16.py
heapq.heappush(q, (d[b], b))
res = {}
for i in range(len(d)):
res[self.id_to_v[i]] = d[i]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужен сам путь, а не длина

@MikhailErofeev
Copy link
Owner

5+
15+, но нейминг плохой, не надо так
16-, нужны самые короткие пути, а не их длины
17+

@fromfall
Copy link
Contributor Author

Обновил 16. Добавьте, пожалуйста, в таблицу баллы за 5, 15, и 17.

@MikhailErofeev
Copy link
Owner

добавил
16+

@MikhailErofeev
Copy link
Owner

разрулите, пожалуйста, мерж конфликт, как-минимум файлы должны в папке фамилии

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fromfall @MikhailErofeev