Broken links - JasonGerend #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#sign-off |
|
For modules in the 2016-ps folder, we should link to cmdlets for 2016, or leave out the view string so that the browser determines the correct version, as I suggest in my first two code comments. Can you fix the rest and then resubmit? Thanks!!! |
JasonGerend
requested changes
Nov 22, 2024
Co-authored-by: Jason Gerend <[email protected]>
Co-authored-by: Jason Gerend <[email protected]>
|
Learn Build status updates of commit 809f483: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Hi @JasonGerend - Thanks for your suggestions, I have updated the PR and would appreciate it if you could help merge it. Thanks! And There is another PR here #3900 , could you review it together? Thank you very much! |
JasonGerend
reviewed
Nov 25, 2024
JasonGerend
requested changes
Nov 25, 2024
JasonGerend
reviewed
Nov 25, 2024
JasonGerend
requested changes
Nov 25, 2024
|
Learn Build status updates of commit 8d113d8: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit f0dd7b0: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit bd7289c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Hi @JasonGerend - I have updated the PR, could you please help approve and merge it, thanks so much! |
|
Learn Build status updates of commit 57e040e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Requested changes have all been incorporated. #sign-off |
dstrome
added
the
Sign off
aditisrivastava07
added
the
PubOps fixes
|
Learn Build status updates of commit a647fe1: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @JasonGerend, I've fixed the broken links. Please verify. Thanks!
See: https://dev.azure.com/msft-skilling/Content/_workitems/edit/340770
PR Summary
PR Checklist