Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update journey-step-3.md #11971

Closed
wants to merge 1 commit into from
Closed

Conversation

hedbergtech
Copy link

Proposing to use New-Guid instead, it will generate a "complex" password easier than having to rely on a custom PSFunction.

Why

  • Closes #[Issue Number]

Changes

Proposing to use New-Guid instead, it will generate a "complex" password easier than having to rely on a custom PSFunction.
@hedbergtech
Copy link
Author

@microsoft-github-policy-service agree [company="Truesec"]

Copy link
Contributor

Learn Build status updates of commit f16bc77:

✅ Validation status: passed

File Status Preview URL Details
windows/security/identity-protection/passwordless-strategy/journey-step-3.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@hedbergtech
Copy link
Author

@microsoft-github-policy-service agree

@paolomatarazzo
Copy link
Contributor

Hello @hedbergtech, new-guid doesn't generate a complex enough string to satisfy most of the password policies out there. the generated string doesn't include any special characters and only lowercase letters.

Copy link
Contributor

@paolomatarazzo paolomatarazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this would be a good idea. The generated GUID is not "complex", other than length.

@paolomatarazzo paolomatarazzo self-assigned this Dec 5, 2024
@hedbergtech
Copy link
Author

On the contrary, a guid always contains a hyphen, which is in fact a "special" character, satisfying the complexity requirement. Changing the character to upper could also ve enforced.

@hedbergtech
Copy link
Author

Making it 3/4 ;). Just a suggestion, totally fine with not having the doc state it

@paolomatarazzo
Copy link
Contributor

fair, - is a special character. Still, most scenarios require upper and lower case too. Since the script has been approved by identity PMs I'm inclined to leave it as-is. Any specific concerns about the function itself? This is a sample script that can be used as a reference...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants