Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- adds detailed allOf rules description #96

Merged
merged 4 commits into from
Jun 13, 2024
Merged

- adds detailed allOf rules description #96

merged 4 commits into from
Jun 13, 2024

Conversation

baywet
Copy link
Member

@baywet baywet commented May 17, 2024

fixes #91

@baywet baywet requested a review from a team as a code owner May 17, 2024 17:22
@baywet baywet self-assigned this May 17, 2024
@baywet baywet enabled auto-merge May 17, 2024 17:23
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
baywet
baywet commented May 24, 2024
View reviewed changes
OpenAPI/kiota/models.md Outdated Show resolved Hide resolved
OpenAPI/kiota/models.md Show resolved Hide resolved
OpenAPI/kiota/models.md Outdated Show resolved Hide resolved
OpenAPI/kiota/models.md Outdated Show resolved Hide resolved
OpenAPI/kiota/models.md Outdated Show resolved Hide resolved
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 9e17d48:

✅ Validation status: passed

File Status Preview URL Details
OpenAPI/kiota/models.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

darrelmiller
darrelmiller approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@darrelmiller darrelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I appreciate you putting in the time to capture these scenarios. Time will tell if it is the best strategy, but at least we have a deterministic approach here.

@baywet baywet force-pushed the feature/all-of-logic branch from 9e17d48 to 8e11c09 Compare June 13, 2024 12:13
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 8e11c09:

✅ Validation status: passed

File Status Preview URL Details
OpenAPI/kiota/models.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@baywet baywet disabled auto-merge June 13, 2024 12:15
@baywet baywet merged commit 52a702f into main Jun 13, 2024
3 checks passed
@baywet baywet deleted the feature/all-of-logic branch June 13, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrelmiller darrelmiller darrelmiller approved these changes

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Kiota model design documentation to fully document allOf behaviour
2 participants
@baywet @darrelmiller