Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify & update "Debug WebView2 apps with Visual Studio" #3233

Merged
merged 29 commits into from
Sep 26, 2024

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Jul 22, 2024

Rendered article for review:

Changes made by this PR:

  • Fixed Issue Wrong screenshot #2775 so that the last png shows a VS screenshot, not a VS Code screenshot.
  • Added "Summary of high-level steps" at top.
  • Updated the article to focus on VS 2022, not 2019.
  • Added all specific steps to reproduce the screenshots; provided the specific steps to follow to use the main wv2 sample (while also allowing to apply to user's own app code base).
    • Instead of abstract steps referring to user's own code base, w/ pngs showing an unspecified code base (turns out to be main wv2 sample).
    • Made article maintainable & testable.
  • Added the missing prerequisite steps (as links) for setting up a new machine that are needed trying to follow the article:
    • Install VS.
      • Which version? was unclear; do install VS 2022 (just mention that 2019 is supported).
    • Clone samples repo.
      • In order to provide & follow specific steps. Enables maintenance & testing the article.
    • Install C++ workload.
      • Or other platform workload.
      • May or may not have been done by user previous to arriving at this article.
    • Compile & run main sample.
      • To use the main sample here, it's best if you already got it compiled & running per sample's article. In this article, just build on that milestone.
      • Starting state: Have the WebView2Samples solution open, WebView2APISample sample app (project) compiles, is not running.
  • In repo, changed 60-char divider comments to standard 40-char (above h4s & some tab h5s).

AB#52806681 - PR Tracking item
AB#45948351 - Issue Tracking item
AB#54124902 - Future test/fix article to hit breakpoint.

@mikehoffms mikehoffms added cat: webview2 WebView-related content. in-progress labels Jul 24, 2024
@mikehoffms mikehoffms changed the title Update png in "Debug WebView2 apps with Visual Studio" Clarify new machine setup using VS 2022 w/o VS 2019 Jul 26, 2024
microsoft-edge/webview2/how-to/debug-visual-studio.md Outdated Show resolved Hide resolved
microsoft-edge/webview2/how-to/debug-visual-studio.md Outdated Show resolved Hide resolved
microsoft-edge/webview2/how-to/debug-visual-studio.md Outdated Show resolved Hide resolved
microsoft-edge/webview2/how-to/debug-visual-studio.md Outdated Show resolved Hide resolved
microsoft-edge/webview2/how-to/debug-visual-studio.md Outdated Show resolved Hide resolved
microsoft-edge/webview2/how-to/debug-visual-studio.md Outdated Show resolved Hide resolved
microsoft-edge/webview2/samples/webview2apissample.md Outdated Show resolved Hide resolved
microsoft-edge/webview2/samples/webview2apissample.md Outdated Show resolved Hide resolved
microsoft-edge/webview2/samples/webview2apissample.md Outdated Show resolved Hide resolved
@mikehoffms mikehoffms changed the title Clarify new machine setup using VS 2022 w/o VS 2019 Show VS not VS Code png in "Debug WebView2 apps with Visual Studio" Aug 1, 2024
@mikehoffms mikehoffms changed the title Show VS not VS Code png in "Debug WebView2 apps with Visual Studio" Clarify & update "Debug WebView2 apps with Visual Studio" Aug 6, 2024
Copy link

Learn Build status updates of commit 142badf:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/webview2/how-to/context-menus.md ✅Succeeded View
microsoft-edge/webview2/how-to/debug-visual-studio-code.md ✅Succeeded View
microsoft-edge/webview2/how-to/debug-visual-studio-images/breakpoint.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/webview2/how-to/debug-visual-studio-images/console.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/webview2/how-to/debug-visual-studio-images/indiv-comp.png ✅Succeeded View
microsoft-edge/webview2/how-to/debug-visual-studio-images/output-tab-vs2022.png ✅Succeeded View
microsoft-edge/webview2/how-to/debug-visual-studio-images/run-local-windows-debugger.png ✅Succeeded View
microsoft-edge/webview2/how-to/debug-visual-studio-images/run.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/webview2/how-to/debug-visual-studio-images/webview-script-debugging-example.png ✅Succeeded View
microsoft-edge/webview2/how-to/debug-visual-studio-images/workloads.png ✅Succeeded View
microsoft-edge/webview2/how-to/debug-visual-studio.md ✅Succeeded View
microsoft-edge/webview2/how-to/publish-uwp-app-store.md ✅Succeeded View
microsoft-edge/webview2/how-to/webresourcerequested.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@mikehoffms mikehoffms requested review from victorhuangwq and removed request for victorhuangwq September 26, 2024 14:19
@captainbrosset captainbrosset merged commit d903666 into main Sep 26, 2024
2 checks passed
@captainbrosset captainbrosset deleted the user/mikehoffms/png-wv2-debug-vs branch September 26, 2024 14:28
@captainbrosset captainbrosset mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: webview2 WebView-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants