Fix propagation of error code in LITTLEFS_read()/LITTLEFS_write() #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwolter
changed the title
|
@fwolter , thank you for reporting the issue and suggesting the fix as well. This will be fixed in the next release of core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comparison
if (*bw < 0)inLITTLEFS_write(..)will always yield false, because*bwis an unsigned pointer. Same for the read function.This yields to
SYS_FS_FileError(..)returning a no-error state whenLITTLEFS_read()/LITTLEFS_write()have been failed.This also fixes the missing mapping from the LittleFS error code to the Harmony error code in
LITTLEFS_read().