Support generating ESM output #387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalLytek
added
enhancement
MichalLytek
requested changes
May 18, 2023
nigelzor
force-pushed
the
emit-esm
branch
2 times, most recently
from
4366ba7 to
ef99728
Compare
|
This is how I'd originally written the change, but I didn't like needing to pass |
Setting `emitESM=true` in the generator's configuration will switch from using `require` to `import` calls in the generated code. I haven't been successful in actually using the ESM output. Bi-directional relationships between models lead to circular dependencies in `*WhereInput` and `*ListRelationFilter` and cause the following error at start-up: > ReferenceError: Cannot access 'FooWhereInput' before initialization > at file:///app/node_modules/@generated/type-graphql/resolvers/inputs/FooListRelationFilter.js:10:31 Regardless of ESM setting, create a package.json if generating into node_modules. This makes sure that the generated code doesn't inherit a parent package's `type`.
|
i second this PR |
|
So esm support not happening anytime soon right? |
|
+1 Need this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #372
Setting
emitESM=truein the generator's configuration will switch from usingrequiretoimportcalls in the generated code.I haven't been successful in actually using the ESM output. Bi-directional relationships between models lead to circular dependencies in
*WhereInputand*ListRelationFilterand cause the following error at start-up:Even without setting
emitESM=true, changing imports to use filenames with extension makes Typescript withmoduleResolution=node16stop complaining about missing types.